DWA Rectangle Robot Type #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation was too slow to work with more obstacles. The calculation function is vectorized to increase the speed.
Add collision check for rectangle robots Add new function to draw robot depending on the type
Owner
|
@goktug97 Thank you for your PR again!!. I have a request. Please check the review. |
Owner
AtsushiSakai
left a comment
AtsushiSakai
left a comment
There was a problem hiding this comment.
Also, could you please add your name at the header comment? You are an author of this code.
- Instead of using string based comparison for robot_type, use Enum class. - Append authors
Owner
|
@goktug97 Cool. I will merge it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a collision check for the rectangular robots.