XCframework support#1978
Conversation
| #if !targetEnvironment(macCatalyst) | ||
| do { | ||
| let result: UInt32? = try AudioKit.engine.outputNode.audioUnit?.getValue(forProperty: kAudioUnitProperty_IsInterAppConnected) | ||
| let result: UInt32? = try AKManager.engine.outputNode.audioUnit?.getValue(forProperty: kAudioUnitProperty_IsInterAppConnected) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)
| #if !targetEnvironment(macCatalyst) | ||
| do { | ||
| let result: UInt32? = try AudioKit.engine.outputNode.audioUnit?.getValue(forProperty: kAudioUnitProperty_IsInterAppConnected) | ||
| let result: UInt32? = try AKManager.engine.outputNode.audioUnit?.getValue(forProperty: kAudioUnitProperty_IsInterAppConnected) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)
| #if !targetEnvironment(macCatalyst) | ||
| do { | ||
| let result: UInt32? = try AudioKit.engine.outputNode.audioUnit?.getValue(forProperty: kAudioUnitProperty_IsInterAppConnected) | ||
| let result: UInt32? = try AKManager.engine.outputNode.audioUnit?.getValue(forProperty: kAudioUnitProperty_IsInterAppConnected) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 138 characters (line_length)
| AudioKit.disconnectAllInputs() | ||
| try! AudioKit.stop() | ||
| AKManager.disconnectAllInputs() | ||
| try! AKManager.stop() |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
| func AKTestNoEffect() { | ||
| if let existingOutput = output { | ||
| try! AudioKit.test(node: existingOutput, duration: duration, afterStart: afterStart) | ||
| try! AKManager.test(node: existingOutput, duration: duration, afterStart: afterStart) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
| func AKTestMD5Not(_ md5: String) { | ||
| if let existingOutput = output { | ||
| try! AudioKit.test(node: existingOutput, duration: duration, afterStart: afterStart) | ||
| try! AKManager.test(node: existingOutput, duration: duration, afterStart: afterStart) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
| func AKTestMD5(_ md5: String, alternate: String = "") { | ||
| if let existingOutput = output { | ||
| try! AudioKit.test(node: existingOutput, duration: duration, afterStart: afterStart) | ||
| try! AKManager.test(node: existingOutput, duration: duration, afterStart: afterStart) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
| func auditionTest() { | ||
| if let existingOutput = output { | ||
| try! AudioKit.auditionTest(node: existingOutput, duration: duration) | ||
| try! AKManager.auditionTest(node: existingOutput, duration: duration) |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
| AudioKit.output = booster | ||
| try! AudioKit.renderToFile(audioFile, duration: 4, prerender: { | ||
| AKManager.output = booster | ||
| try! AKManager.renderToFile(audioFile, duration: 4, prerender: { |
There was a problem hiding this comment.
Force Try Violation: Force tries should be avoided. (force_try)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Loading configuration from '.swiftlint.yml'
Loading configuration from '.swiftlint.yml' Linting Swift files at paths AudioKit/Common/MIDI/AKMIDIInstrument.swift Linting 'AKMIDIInstrument.swift' (1/1)
3 participants
This lays the groundwork for producing a working XCFramework. The main change is the
AudioKitclass was renamed toAKManagerin order to avoid a clash with the module name. As such, it should be a new major release of AudioKit (say v5.0).I've updated enough of the examples and tests to pass Travis, but there's more work to be done on that front.
I'm also going to try to add support for Github Actions soon as a replacement for Travis, since its build system should be able to handle our needs better and should be able to produce and upload the XCFrameworks.