Fix quote math - #410
Merged
Merged
Conversation
dharit-tan
approved these changes
Sep 22, 2025
dylanjeffers
added a commit
that referenced
this pull request
Jul 27, 2026
…ing (stems invisible since ~Jul 12 cutover) (#995) ## TL;DR `/v1/tracks/{id}/stems` fails the entire request when any selected column scans NULL into a non-pointer Go field, and every stem indexed by the Go ETL since the ~July 12 Python→Go cutover has NULL `orig_filename`. The result was a **silent 500** that made the stems section / ContestStemsCard blank for post-cutover uploads — most visibly Andrew Lux's "Alone" remix contest (parent `JBKl7R6`, 43 stems uploaded 7/20, all correct on-chain). #973 fixed the `orig_filename` case on main (June 23), but this PR closes the remaining NULL-scan path (`stem_of` wiped → `category`/`parent_track_id` NULL) and adds regression coverage. ## Root cause chain 1. **The Go ETL never persists `orig_filename`** — the entity-manager create handler doesn't extract it, so only legacy Python-indexed rows carry a value. Verified against the raw on-chain txs (core blocks 28480416–28480440): the metadata contains `orig_filename` and a correct `stem_of`, and replaying the exact tx through the vendored ETL persists `stem_of` fine. 2. **The endpoint scanned NULLs into non-pointer `string`/`int` fields** (`pgx.RowToStructByName`), so one ETL-shaped row 500s the whole response — every stem on the parent disappears, not just the affected one. 3. #973 (June 23) fixed the `orig_filename` scan via `COALESCE(orig_filename, title, '')`. Prod is running `915c37d` today (pods restarted 2026-07-26 08:07 UTC), which includes it — but the incident behavior on 7/20–7/25 is consistent with the pods running a **pre-#973 build** until that 7/26 restart. Worth confirming from deploy history (`kubectl --context prod -n api rollout history` / image tags). 4. **Still broken until this PR:** a `stems` join row can outlive `tracks.stem_of`. An explicit `"stem_of": null` in a client update wipes the column (clients send the full track object on edit — same failure class as the CID wipe fixed in OpenAudio/go-openaudio#410) while the `stems` row survives. `category` and `parent_track_id` then come back NULL from the jsonb and the request 500s again. ## Fix - `COALESCE(t.stem_of->>'category', '')`, `COALESCE(t.track_cid, '')` - `parent_track_id` now read from the `stems` join key (never NULL) instead of the jsonb - Regression test `TestGetTrackStemsWipedStemOf`: seeds a stems row whose track has no `stem_of`/`orig_filename` — 500 before, 200 after ## Blast radius Every stem uploaded after the ~July 12 cutover was invisible in the UI while the NULL-scan bug was live (any parent with ≥1 ETL-shaped stem row 500'd). The DB rows themselves are intact — once the endpoint tolerates NULLs, existing stems reappear with no reindex. ## Andrew Lux follow-up (support) Andrew deleted all of his stems while debugging (one on 7/25 13:38 UTC after 9 retries, a fresh batch uploaded 7/25 14:08–14:50, then a bulk on-chain `Track/Delete` of everything on 7/27 12:35 UTC). Deleted tracks can't be un-deleted on-chain, so **after this deploys he needs to re-upload the stems once** via Edit Track → stems on "Alone" — the same flow he used before; nothing was wrong with his uploads. ## Go ETL follow-ups (OpenAudio/go-openaudio — patches staged locally, separate PR) - [ ] Persist `orig_filename` on track create/update (Python parity; never-clear like the CIDs) so new rows don't rely on the title fallback - [ ] Ignore explicit `"stem_of": null` in track updates (same guard as the #410 CID fix) so client edits can't unlink stems - [ ] Upsert the `stems` join row when an update carries `stem_of` (also gives us an on-chain repair path for lost links) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
dylanjeffers
added a commit
that referenced
this pull request
Jul 27, 2026
…audio#421) (#996) Bumps both `github.com/OpenAudio/go-openaudio` and `.../pkg/etl` pins from `b4a5ebe` (2026-07-16) to `1d9f697` — the merge of **OpenAudio/go-openaudio#421**, same flow as #994 did for the #410 CID fix. ## What the new pin brings (ETL / entity manager) - Persist `orig_filename` on track create/update (never-clear, like the CIDs) — new stem rows no longer rely on the `/stems` endpoint's title fallback - Ignore explicit `"stem_of": null` on track updates so client edits can't unlink a stem from its parent (#410 failure class) - Upsert the `stems` join row when an update carries `stem_of` (on-chain repair path for lost links) Intervening upstream commits also included (library-only for api): mediorum transcode/retry fixes (#338, #417–#419) and core/logging spam guards (#420). Nothing release- or mainnet-config-related. ## Relation to #995 #995 is the unblocking change (endpoint tolerates NULLs already in the DB); this bump prevents recurrence at the write path. Both trace back to the July stems-invisible incident (Andrew Lux's "Alone" remix contest). Verified locally: `go build ./...`, stems endpoint tests, and `go test ./indexer/...` all pass on the new pin. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.