Update coin description + social links - #429
Merged
Merged
Conversation
dharit-tan
requested review from
faridsalau,
raymondjacobson,
rickyrombo and
schottra
September 29, 2025 21:08
rickyrombo
reviewed
Sep 29, 2025
raymondjacobson
approved these changes
Sep 29, 2025
schottra
reviewed
Sep 30, 2025
|
|
||
| row := app.writePool.QueryRow(c.Context(), sql, args) | ||
|
|
||
| var result struct { |
Contributor
There was a problem hiding this comment.
I'm curious why we are returning all of this? Is the goal to merge it into the client side cache? Mostly concerned because it's not the full fieldset from /v1/coins (here), so we would have to be careful not to just replace the client side object.
Contributor
Author
There was a problem hiding this comment.
i also was wondering this, maybe better to just not return?
do we have a similar update endpoint whose conventions i can follow?
|
|
||
| assert.Equal(t, 403, status) | ||
| jsonAssert(t, body, map[string]any{ | ||
| "error": "You do not own this coin", |
Contributor
There was a problem hiding this comment.
I continue to think that testing the exact content of these messages is brittle and unnecessary. But I might be in the minority. :-)
rickyrombo
approved these changes
Sep 30, 2025
| args := pgx.NamedArgs{"mint": mint} | ||
| hasUpdates := false | ||
|
|
||
| if body.Description != "" { |
Contributor
There was a problem hiding this comment.
Is unsettling the description allowed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST endpoint to update artist coin description + social links
seems like we forgot to update
swagger-v1-full.yamlwith/coinget endpoint so adding that too.