Adapt rewards to the new RewardPool primitive

[rickyrombo]

Summary

Adapts the two CreateReward call sites in this repo to the new cometbft RewardPool primitive shipping in go-openaudio v1.2.13 (OpenAudio/go-openaudio#254). Without this, the launchpad reward-code flow breaks at deploy: the new CreateReward proto reserves the old claim_authorities / deadline_block_height fields, and the validator now refuses any CreateReward whose RM has no pool.

Why

The pool primitive moves the eth addresses authorized to attest for programmatic rewards off each core_rewards row and onto a core_reward_pools row keyed by the Solana RM pubkey. Rewards now reference a pool by rewards_manager_pubkey; the pool's authority set is mutable via cometbft transactions; validators consult the pool's current authorities when serving claim attestations. Rotation becomes a one-row update instead of mass row reissuance.

For us to call CreateReward, a pool keyed by the mint's RM must already exist. Brand-new mints need a one-time CreateRewardPool call first.

What changed

utils/derive_reward_manager_keypair.go (new)

DeriveRewardManagerKeypair(secretHex, mint) ed25519.PrivateKey returns the deterministic ed25519 keypair the solana-relay used to init the Solana reward manager state account for a given mint. Seed material matches apps/.../solana-relay/.../launchpad/launch_coin.ts's deriveKeypair('reward-manager', mint):

seed = sha256(secret_utf8 || "audius-launchpad" || "reward-manager" || mint_bytes)

The returned private key's public key IS the rewards_manager_pubkey cometbft carries. Used to sign CreateRewardPool's envelope-level ed25519 rm_owner_signature, which is the frontrunning defense — only callers who hold the launchpad's deterministic secret can produce it.

api/v1_create_reward_code.go and cmd/create_reward_codes/main.go

Both rewards code paths reshaped identically:

1. Derive the RM keypair for this mint (above).
2. Ensure the pool exists: oap.Rewards.GetRewardPool(rewardsManagerPubkey). If CodeNotFound, call oap.Rewards.CreateRewardPool(...) with the RM private key as the new rmKey argument. Pool authorities = the per-mint claim authority eth address (the existing DeriveEthAddressForMint output).
3. Submit CreateReward with RewardsManagerPubkey: rewardsManagerPubkey. The legacy ClaimAuthorities slice and inline DeadlineBlockHeight are gone (proto tags 4–6 reserved on CreateReward); deadline is now a separate SDK argument.

The CLI's "reward already exists, look up the stored address" idempotency path is preserved. The HTTP path's no-op behavior when LaunchpadDeterministicSecret is unset is preserved.

go.mod

github.com/OpenAudio/go-openaudio v1.2.11 → v1.2.13 (pseudo-version pointing at the merge commit).

Test plan

• go build ./... and go vet ./... clean.
• go test ./utils/... — new TestDeriveRewardManagerKeypair covers well-formedness, determinism, sign/verify round-trip, and that different mints / secrets produce different keypairs (5 subtests).
• After merge: bump go.mod to the clean v1.2.13 tag once go-openaudio cuts it.
• Devnet smoke: launch a new coin via the launchpad-relay, POST /v1/rewards/code, observe the first call creates both the pool and the reward, subsequent calls for the same mint create only the reward.
• Staging: run the CLI against a fresh mint; verify the same two-call pattern then the idempotent reuse path on a second run.

Dependencies

• Blocked on: OpenAudio/go-openaudio#254 (merged).
• Coordinated with: OpenAudio/go-openaudio#260 (the v1.2.13 version bump; this PR's go.mod pseudo-version will be rewritten to the clean tag after that lands).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Updates the launchpad reward-code creation flows to work with the new cometbft RewardPool primitive in go-openaudio, including deterministic derivation of the Solana rewards manager (RM) keypair so the API/CLI can create reward pools when needed.

Changes:

• Add DeriveRewardManagerKeypair(secretHex, mint) utility (+ tests) to deterministically derive the RM ed25519 keypair used for CreateRewardPool signing.
• Update both HTTP (/v1/rewards/code) and CLI reward-code creation to (a) derive RM pubkey, (b) ensure the pool exists, then (c) create the reward referencing RewardsManagerPubkey.
• Bump github.com/OpenAudio/go-openaudio to the v1.2.13 pseudo-version that includes the RewardPool API.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
utils/derive_reward_manager_keypair.go	Adds deterministic RM ed25519 key derivation used to sign pool creation.
utils/derive_reward_manager_keypair_test.go	Tests derivation determinism and sign/verify behavior.
api/v1_create_reward_code.go	Updates API reward-code flow to ensure reward pool exists and create rewards by RewardsManagerPubkey.
cmd/create_reward_codes/main.go	Updates CLI flow to ensure reward pools exist and create rewards via RewardsManagerPubkey, with retries/idempotency.
go.mod	Bumps go-openaudio dependency to include RewardPool changes.
go.sum	Updates dependency checksums accordingly.

Comments suppressed due to low confidence (2)

cmd/create_reward_codes/main.go:292

• This error message says "failed to create reward pool" but the call now both ensures the pool and creates the reward. Updating the message will make CLI failures easier to diagnose.

		return CodeResult{
			Code:    code,
			Success: false,
			Error:   fmt.Sprintf("failed to create reward pool: %v", err),
		}

cmd/create_reward_codes/main.go:369

• Similarly, detecting an existing reward by strings.Contains(err.Error(), "already exists") is fragile. If CreateReward returns a connect error (or can be made to), prefer checking connect.CodeAlreadyExists (or another stable error type/code) rather than parsing the message.

		if err != nil && strings.Contains(err.Error(), "already exists") {
			logger.Info("Reward already exists", zap.String("code", code))
			return &RewardExistsError{Code: code}
		}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

cmd/create_reward_codes/main.go:326

• The doc comment for ensurePoolAndCreateReward is out of date and no longer matches the implementation. It says the "reward already exists in pool" case is "detected via the cometbft error string and resolved by reading the previously stored reward_address from the local DB — the idempotency guarantee the prior implementation provided is preserved." However, the substring-based detection, the RewardExistsError plumbing, and the DB-based reward_address lookup were all removed in this PR. The function now relies on the early checkCodeExists in processCode for idempotency and surfaces any CreateReward error directly. The comment should be updated to reflect the new flow.

// ensurePoolAndCreateReward looks up (and if missing, creates) the reward
// pool for the mint, then submits the CreateReward tx and returns the
// reward address. The "reward already exists in pool" case is detected
// via the cometbft error string and resolved by reading the previously
// stored reward_address from the local DB — the idempotency guarantee
// the prior implementation provided is preserved.
func ensurePoolAndCreateReward(ctx context.Context, logger *zap.Logger, pool *pgxpool.Pool, oap *sdk.OpenAudioSDK, code string, amount int64, claimAuthority, rewardsManagerPubkey string, rmKey ed25519.PrivateKey) (string, error) {

cmd/create_reward_codes/main.go:326

• The pool *pgxpool.Pool parameter passed to ensurePoolAndCreateReward is no longer used inside the function (the previous DB lookup for reward_address on the "already exists" path was removed). Consider dropping the parameter from the signature and the call site to avoid dead arguments.

func ensurePoolAndCreateReward(ctx context.Context, logger *zap.Logger, pool *pgxpool.Pool, oap *sdk.OpenAudioSDK, code string, amount int64, claimAuthority, rewardsManagerPubkey string, rmKey ed25519.PrivateKey) (string, error) {

cmd/create_reward_codes/main.go:293

• The error string "failed to create reward pool" is now misleading: ensurePoolAndCreateReward performs two distinct submissions (the pool ensure step and the CreateReward call), and any error from the CreateReward path will be surfaced here labeled as a pool-creation failure. Consider using a more accurate wording (e.g. "failed to create reward" or "failed to ensure pool and create reward") to aid debugging.

This issue also appears in the following locations of the same file:

• line 320
• line 326

	rewardAddress, err := ensurePoolAndCreateReward(ctx, logger, pool, oap, code, amount, claimAuthority, rewardsManagerPubkey, rmKey)
	if err != nil {
		return CodeResult{
			Code:    code,
			Success: false,
			Error:   fmt.Sprintf("failed to create reward pool: %v", err),
		}
	}