Version v1.2.13: reward authority rotation primitive (RewardPool)#260
Merged
Conversation
Ships PR #254. Adds CometBFT-side `RewardPool` so the eth addresses authorized to attest for programmatic rewards under a Solana RM can be updated without reissuing reward rows. Unblocks the artist-coin attestation kill-switch from v1.2.11/#215. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
5 tasks
raymondjacobson
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ships as v1.2.13 (
.version.jsonbumped in this PR). Releases theRewardPoolcometbft primitive merged in #254, which unblocks the artist-coin attestation kill switch added in v1.2.11 (#215).What's in v1.2.13
PR #254 — Reward authority rotation primitive (RewardPool):
00034_reward_pools.sql): newcore_reward_poolstable keyed by the Solana RM pubkey;core_rewards.rewards_manager_pubkeyFK with reads aliased asclaim_authoritiesvia LEFT JOIN.launchpad_authority_rmseed table maps each per-mint claim authority eth address → its Solana RM, backfilling existing reward rows to real-RM-bound pools. The legacycore_rewards.claim_authoritiescolumn is dropped.CreateRewardPoolandSetRewardPoolAuthoritiesactions.CreateRewardnow requires an existing pool; signer must be in the pool's authorities.CreateRewardPooladditionally requires an ed25519rm_owner_signatureover the body bytes, produced by the RM's keypair — defeats pool-creation frontrunning by an observer who watches Solana RM init events but lacks the launchpad's deterministic secret.GetRewardAttestationrestored from the Temporarily block artist-coin attestations at the node #215 kill switch; auth check uses the pool's current authorities so rotation immediately revokes attestation rights.GetRewardSenderAttestation/GetDeleteRewardSenderAttestationgate per-RM (pool members for pool-managed RMs; validator/AAO trust set only for the configured AUDIO RM; everything else is refused).validateCreateRewardPoolrefuses the configured AUDIO RM, so AUDIO attestation authority remains on the network-wide trust set.What changed
pkg/version/.version.json:1.2.12→1.2.13.Implications for rollout
This release pairs with corresponding API-repo work (deferred from PR #254) that lands
CreateRewardPoolcalls beforeCreateRewardfor new launchpad mints. Until that ships, new mints will fail atvalidateCreateReward's pool-existence check. Existing mints work via the migration backfill.The wire-compat layer keeps the chain replayable for any node bootstrapping from genesis. PR #232 (separate, post-network-restart cleanup) strips it later.
Test plan
Create Releaseworkflow withversion=v1.2.13edgeand verify the AUDIO denylist is active in the chosen environment (AudioRewardsManagerPubkey()returns the expected RM)CreateRewardPoolintegration test against devnet round-trips: pool created → reward created against pool → authority rotated viaSetRewardPoolAuthorities→ rotated-out authority can no longer attest🤖 Generated with Claude Code