Optimize notification unread polling#987
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limit=0notification unread polling behind the fast single-recipient path before touching the broader multi-recipient GIN scan.notification.user_idsrows.Live analysis
/v1/notifications/:userId504s were low-volume but concentrated in a few users, with requests timing out at the 8s notification read deadline.DvEvv/77214improved the unread poll shape from roughly 132ms / 39,651 buffer hits to roughly 14ms / 1,132 buffer hits by avoiding the multi-recipient branch when the single-recipient branch already satisfied the capped unread count.eJ57D/51showed the same branch-elision behavior.Testing
go test ./api -run '^$'git diff --checkNote: focused notification integration tests could not run locally because the local test Postgres at
localhost:21300was not running.