Skip to content

Delete pc challenge#11561

Merged
faridsalau merged 2 commits intomainfrom
fs-delete-pc
Mar 10, 2025
Merged

Delete pc challenge#11561
faridsalau merged 2 commits intomainfrom
fs-delete-pc

Conversation

@faridsalau
Copy link
Copy Markdown
Contributor

@faridsalau faridsalau commented Mar 10, 2025

Description

Renamed the challenge id for playcount, users with stale data will have errors

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6c54c94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@faridsalau faridsalau requested a review from dharit-tan March 10, 2025 18:17
dharit-tan
dharit-tan reviewed Mar 10, 2025
View reviewed changes
Comment thread packages/discovery-provider/ddl/migrations/0123_delete_pc_challenge.sql Outdated
IF EXISTS (
SELECT *
FROM "blocks"
WHERE "blockhash" = '0x65a3243860511ed28a933c3a113dea7df368ad53f721cc9d0034c0c75f996afb'
Copy link
Copy Markdown
Contributor

@dharit-tan dharit-tan Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't seen this pattern before but if ur confident in it then ship it. at the same time we could probably just blanket delete pc challenges on prod as well since none should exist yet, and if they did we'd want to delete them.

@faridsalau faridsalau requested a review from dharit-tan March 10, 2025 18:20
@faridsalau faridsalau enabled auto-merge (squash) March 10, 2025 18:21
@faridsalau faridsalau disabled auto-merge March 10, 2025 18:22
@faridsalau faridsalau merged commit ba9b8fb into main Mar 10, 2025
@faridsalau faridsalau deleted the fs-delete-pc branch March 10, 2025 18:22
audius-infra pushed a commit that referenced this pull request Mar 11, 2025
Audius Protocol v0.7.108
a41006c 
[4a0e8cc] dual write to acdc and core (#11573) alecsavvy
[2f859fb] fix attest endpoint (#11552) Steve Perkins
[6fc5376] Remove end_date on play count challenge and update query (#11563) Farid Salau
[5bebab8] [PAY-3893][PAY-3894] Remove legacy indexing of associated_wallets and collectibles (#11564) Randy Schott
[00a19f0] Fix marshalling for playlist notifs (#11562) Randy Schott
[ba9b8fb] Delete pc challenge (#11561) Farid Salau
[84eb2f8] [PAY-3979][PAY-3990] Update play count challenge BE and Add the FE (#11521) Farid Salau
faridsalau added a commit that referenced this pull request Mar 19, 2025
@faridsalau
Delete pc challenge (#11561)
23315e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dharit-tan dharit-tan dharit-tan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@faridsalau @dharit-tan