Merged
Conversation
|
raymondjacobson
approved these changes
Mar 10, 2025
audius-infra
pushed a commit
that referenced
this pull request
Mar 11, 2025
[4a0e8cc] dual write to acdc and core (#11573) alecsavvy [2f859fb] fix attest endpoint (#11552) Steve Perkins [6fc5376] Remove end_date on play count challenge and update query (#11563) Farid Salau [5bebab8] [PAY-3893][PAY-3894] Remove legacy indexing of associated_wallets and collectibles (#11564) Randy Schott [00a19f0] Fix marshalling for playlist notifs (#11562) Randy Schott [ba9b8fb] Delete pc challenge (#11561) Farid Salau [84eb2f8] [PAY-3979][PAY-3990] Update play count challenge BE and Add the FE (#11521) Farid Salau
5 tasks
stereosteve
added a commit
to AudiusProject/api
that referenced
this pull request
Jul 17, 2025
TODO: * [ ] Do we need all the `timestamp_offset, group_id_offset` query logic? Does the client use some, all or none of those query params? * [ ] `playlist_id` is weirdly a list, as discussed here: AudiusProject/apps#11562 * [x] Ordering of items inside of `actions` array may diverge. Will need a subquery there. * [x] The `seen_at` is never null in the golang version.. not sure why that's different. * [x] Need the unread count field Questions: * Difference in `seen_at` null behavior? * limit=0 returns results from python server? * playlist_id as array... is that for the client or for the python? Changes: * Added `valid_types` support, but`timestamp_offset` and `group_id_offset` query logic is problematic and I don't understand what it's supposed to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Missed a spot in #11511.
Playlist notifs were, for some reason, extending the playlist_id as a tuple and not a list.
I'm not entirely sure why the output model uses a list when it's usually one item. But for the sake of backwards compatibility, I'm not going to change that. This will, however, remove a bunch of error messages from the logs due to the id being in the wrong format.
How Has This Been Tested?
Local client against local stack. User B follows User A. User A uploads a playlist and album. Check notifications on user B. Check logs for server container to make sure no more marshaling errors.