feat(ingest): iceberg/parquet support, parallel tag scan, openpyxl, tag-contract docs - #4
Merged
Merged
Conversation
- port write_parquet_to_db into g3dt.utils.athena_utils so ingest can append to legacy plain-Parquet Glue tables - rename ingest_table/files_to_parquet_dataset to ingest_table/files_to_dataset with a validated table_format flag (iceberg default, parquet requires dataset_root) and keep deprecated delegating aliases for existing callers - scan S3 object tags concurrently in get_ingest_true_files (max_workers, boto connection pool sized to match) since one GetObjectTagging round-trip per file was the bottleneck on large buckets - replace the mutable exclude_fn default argument with None plus an in-body default
read_xlsx_robust uses engine="openpyxl" but it was never declared, so xlsx ingest failed at runtime rather than install time.
Explains the ingest=true opt-in tag, why untagged objects are silently skipped, the IAM and tag-propagation sharp edges, the ingest_* provenance columns and row-hash dedup semantics, and the iceberg/parquet table_format options, with a worked tag-to-Athena example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the toolkit's ingest helpers up to the reference implementation's final state:
ingest_table_to_dataset/ingest_files_to_datasetwithtable_format(iceberg default | parquet), plus back-compat*_to_parquet_datasetshims (the old names always wrote Iceberg)write_parquet_to_dbported (was missing entirely)max_workers) replacing the serial per-object loopopenpyxl>=3.1.0declared (xlsx ingest failed at runtime, not install)ingest=truetag contract written for someone who didn't invent it — silent-skip semantics, IAM needs, tags-lost-on-copy, the provenance columns, and whatingest_row_hashdoes and doesn't guaranteeThese helpers remain optional bring-your-own-ingestion utilities; the supported no-code path is gen3-metadata-templates → bronze.
302 tests pass.