fix dropdown in wizard flow + table in detail view - #4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Textual UI layer to (1) render wizard choice fields with an inline option list (so choices can be populated/displayed reliably in the wizard flow) and (2) allow the workbench detail pane to render a tabular detail view.
Changes:
- Replace wizard
CHOICEform fields fromSelecttoOptionList, with inline option rendering and keyboard navigation. - Add support for rendering
TableViewinside the workbench detail pane, including row-count subtitle. - Add/extend smoke and contract tests validating the new wizard choice behavior and detail table rendering.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_wizard_contracts.py | Adds an app-level test exercising dynamic choice rendering and submission via OptionList. |
| tests/test_app_smoke.py | Adds a smoke test asserting TableView renders as a DataTable in the detail pane. |
| src/groundskeeping/widgets/workbench.py | Adds TableView support for detail rendering via show_detail_table(). |
| src/groundskeeping/widgets/wizard.py | Updates choice field rendering to use OptionList and maps selection back into submitted values. |
| src/groundskeeping/contracts/views.py | Expands DetailView union type to include TableView. |
| README.md | Documents that the lower-right detail pane can now render TableView. |
| docs/pages.md | Documents when to use a detail TableView in the workbench layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix to allow population of dropdown menu in wizard workflow + adding table view within the detail pain
Checklist
breaking,feature,fix,dependencies, orchore)uv run pytest -q)uv run ruff check .)