Skip to content

Conversation

@thepoetdj
Copy link
Contributor

@thepoetdj thepoetdj commented Dec 12, 2025

Closes #481

This PR introduces a TemporalType with support for following property types:

  • LocalDate
  • LocalTime
  • LocalDateTime

Multiple default formats are provided for each individual property type mentioned above.

TemporalType is kept open for the implementation of types that are not provided by default (e.g. YearMonth).

Following export rule is followed for each of the property type mentioned above and for any derived types:

  • The format that matched during the convert operation, otherwise
  • Defaults to use the first available supported format provided during initialization

Support for these property types is also provided for the bean mapper.

@thepoetdj thepoetdj changed the title Introducing TemporalType Issue #481 - Introducing TemporalType Dec 12, 2025
@thepoetdj thepoetdj changed the title Issue #481 - Introducing TemporalType #481 introducing TemporalType Dec 12, 2025
@thepoetdj thepoetdj changed the title #481 introducing TemporalType Introducing TemporalType Dec 12, 2025
@ljacqu ljacqu self-assigned this Dec 15, 2025
@ljacqu
Copy link
Member

ljacqu commented Dec 15, 2025

Thanks for this PR! I could only go through it fast today but will see it in detail tomorrow. First impression is that it looks great :)

I had to approve the builds and it looks like there's a test failure or something (I haven't had the time to check). Sorry for the late feedback, not sure why I have to approve these runs

@thepoetdj
Copy link
Contributor Author

I had to approve the builds and it looks like there's a test failure or something (I haven't had the time to check).

Let me have a look at those failed tests.

@thepoetdj
Copy link
Contributor Author

I had to approve the builds and it looks like there's a test failure or something (I haven't had the time to check).

Let me have a look at those failed tests.

These should run correctly now.

@ljacqu
Copy link
Member

ljacqu commented Dec 18, 2025

Looks wonderful, sorry for the long wait! Thanks for implementing this.

@ljacqu ljacqu merged commit 5a66ea4 into AuthMe:master Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Property types for LocalDate, LocalDateTime and LocalTime

2 participants