fix: add types folder into packages#216
Merged
Conversation
kachkaev
reviewed
Aug 17, 2020
| { | ||
| "name": "react-base-table", | ||
| "version": "1.11.0", | ||
| "version": "1.11.1", |
There was a problem hiding this comment.
Good point! Guess that bumping package version is outside of the PR’s scope :)
Contributor
|
You beat me to the punch. We can either bundle the types or publish them to @DefinitelyTyped. |
nihgwu
changed the title
Contributor
|
@jamesonhill never mind |
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the typescript d.ts file is not packaged into the npm bundle, we should include it :P