Skip to content

add aria label to analytics decline button - #1367

Merged
PepperLola merged 2 commits into
devfrom
dionkud/aria-cookie-decline
Jul 1, 2026
Merged

add aria label to analytics decline button#1367
PepperLola merged 2 commits into
devfrom
dionkud/aria-cookie-decline

Conversation

@0xda157

@0xda157 0xda157 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Task

part of SYNTH-14

Symptom

Solution

Verification


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157
0xda157 requested review from a team as code owners June 30, 2026 21:23
@PepperLola
PepperLola enabled auto-merge (squash) July 1, 2026 00:09
@PepperLola
PepperLola merged commit f7738ff into dev Jul 1, 2026
16 checks passed
@PepperLola
PepperLola deleted the dionkud/aria-cookie-decline branch July 1, 2026 00:11
BrandonPacewic added a commit that referenced this pull request Jul 1, 2026
* 'dev' of github.com:Autodesk/synthesis: (64 commits)
  Improve styling of joint sequencing panel `[SYNTH-188]` (#1366)
  Snap Field Placement `[SYNTH-94]` (#1368)
  fix: inverted joystick control scheme
  add aria label to analytics decline button (#1367)
  Remove Electron Icons `[SYNTH-203]` (#1369)
  Fix Gamepad custom selection `[SYNTH-152]` (#1361)
  Increase Minimum Sphericity to 0.99
  Sphere Game Piece Unit Tests
  Update ConfigureShotTrajectoryInterface.tsx
  Style Fixes
  style: fix
  fix: provide backup values to prevent crashing
  fix: remove move handle from modal headers
  feat: support transaltion + rotation; needed feedforward logic
  Style Fixes
  Disable Focus Selection on "None" and Field
  Style Fix
  Prevent Changing Mode while Focus is on a Field
  Biome Style Fixes
  Minor tootlip text improvement
  ...
BrandonPacewic added a commit that referenced this pull request Jul 1, 2026
* 'dev' of github.com:Autodesk/synthesis: (86 commits)
  Improve styling of joint sequencing panel `[SYNTH-188]` (#1366)
  Snap Field Placement `[SYNTH-94]` (#1368)
  fix: inverted joystick control scheme
  add aria label to analytics decline button (#1367)
  Remove Electron Icons `[SYNTH-203]` (#1369)
  Fix Gamepad custom selection `[SYNTH-152]` (#1361)
  Increase Minimum Sphericity to 0.99
  Sphere Game Piece Unit Tests
  Update ConfigureShotTrajectoryInterface.tsx
  Style Fixes
  style: fix
  fix: provide backup values to prevent crashing
  fix: remove move handle from modal headers
  feat: support transaltion + rotation; needed feedforward logic
  Style Fixes
  Disable Focus Selection on "None" and Field
  Style Fix
  Prevent Changing Mode while Focus is on a Field
  Biome Style Fixes
  Minor tootlip text improvement
  ...
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants