Fix dangerous use of value of token constants #840
Merged
Conversation
The value of tokens constants is not guaranteed, so should never be compared against directly. Either use the token 'code' and compare against the constant (preferred). Or use the token 'type' and compare against the constant name. But **_never_** compare against the value of the constant. Comparing against the 'type' should generally only be needed for tokens which may not exist in older PHPCS/PHP versions.
jrfnl
changed the title
GaryJones
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dangerous use of value of token constants
The value of tokens constants is not guaranteed, so should never be compared against directly.
Either use the token 'code' and compare against the constant (preferred).
Or use the token 'type' and compare against the constant name.
But never compare against the value of the constant.
Comparing against the 'type' should generally only be needed for tokens which may not exist in older PHPCS/PHP versions.
Fix unnecessary comparison against token type