Require WordPressCS 3.4.1 and align dependency floors - #892
Merged
Conversation
WordPressCS 3.4.1 is a security release, and 3.3.0-3.4.1 also improve the accuracy of several sniffs that VIPCS bundles, so requiring it passes both benefits on to VIPCS users. The other coding-standard floors are raised in step to match what WordPressCS 3.4.1 itself requires: PHP_CodeSniffer 3.13.5, PHPCSUtils 1.2.3, PHPCSExtra 1.5.1 and VariableAnalysis 2.13.0. The README requirements and the PHPCompatibility testVersion (now 7.4-, matching the existing PHP floor) are brought back into sync, as both had drifted from composer.json.
This was referenced Jul 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WordPressCS 3.4.1 is a security release (advisory GHSA-3pwp-g2mj-5p3v), and the 3.3.0–3.4.1 line also brings a number of accuracy improvements to WordPressCS sniffs that VIPCS bundles and runs. Raising the minimum requirement passes both on to VIPCS users.
The vulnerability itself is in the
WordPress.WP.EnqueuedResourceParameterssniff, which neither VIPCS ruleset enables, so this does not change VIPCS' own behaviour. It is a dependency-hygiene bump: it removes the affected WordPressCS releases from users' dependency trees and protects anyone who additionally runs theWordPressorWordPress-Extrastandards.The remaining coding-standard floors are raised in step to match what WordPressCS 3.4.1 itself requires — PHP_CodeSniffer 3.13.5, PHPCSUtils 1.2.3 and PHPCSExtra 1.5.1 — along with VariableAnalysis 2.13.0. The README "Minimal requirements" and the PHPCompatibility
testVersion(now7.4-, matching the existing PHP floor) are brought back into sync, as both had drifted fromcomposer.json.This is the dependency portion of the 3.1.0 release; the changelog will follow on the release branch.
Test plan
composer updateresolves WordPressCS 3.4.1, PHP_CodeSniffer 3.13.5, PHPCSUtils 1.2.3, PHPCSExtra 1.5.1 and VariableAnalysis 2.13.0composer test-ruleset,composer test,composer feature-completenessandcomposer csall passcomposer auditreports no advisories