Do not classify fixed-position skip links as button blocks - #767
Open
chubes4 wants to merge 2 commits into
Open
Conversation
AI assistance: model gpt-5.6-sol using OpenCode identified the generic positioned-fragment navigation classification repair and added regression coverage. Chris Huber is responsible for every line.
AI assistance: model gpt-5.6-sol using OpenCode implemented the valid zero-flow carrier for positioned fragment links and extended regression coverage. Chris Huber is responsible for every line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Fixed and absolute fragment-navigation anchors can carry the same visual surface declarations as calls to action.
ButtonsPatterntherefore promoted skip links tocore/button, moving their fixed geometry onto generated button wrappers.Generic fix
Classify positioned, non-button fragment links as native anchors before button matching in both single-anchor and anchor-row paths. Their valid paragraph carrier is marked
display: contentsso it does not introduce document flow, while the source anchor retains selectors and focus behavior. Ordinary styled fragment CTAs and explicitrole="button"controls continue through core button conversion.Tests
php tests/unit/button-signal-classifier.php(32 assertions)composer test(canonical contracts, unit suite, 258 parity fixtures, package install proof)Fixture-89 Evidence
Final combined SHA:
50309edbc004370de3f3c2468f013b0eee4fa1ce0/10,325,760170/170340/3401280x8067Fixes #756.
AI assistance
model gpt-5.6-sol using OpenCode analyzed the classifier path, rebuilt the commits with disclosure, implemented the generic repair, and ran verification. Chris Huber is responsible for every line.