Desktop: lock down and test the packaged app - #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #397 and #403.
Embedded web content now gets only the Electron permissions Cortext needs. Fullscreen still works for HTTPS embeds, while access to the camera, microphone, screen capture, location, clipboard reads, and connected devices is blocked. Packaged builds also hide DevTools and disable unused Node and inspector entry points.
Buildkite now checks and opens the signed and notarized
.appbefore uploading it. This verifies its security fuses and bundled runtime files, then checks startup, local runtime authentication, second-instance handling, and clean shutdown.Why
Cortext loads web embeds inside Electron, so the app should grant only the permissions they need.
Our current E2E tests run Electron from source and cannot catch failures that only affect the packaged app. Signing and notarization do not prove that the
.appstarts, so CI should open it before uploading it.How
file://access.Testing Instructions
I used Claude to help implement these changes. I guided the work, then tested and reviewed the result.