Skip to content

Revert "Middleware: Pass non-branch query parameters on redirect"#84

Merged
sirreal merged 1 commit intomasterfrom
revert-81-update/pass-query-params
Jan 12, 2019
Merged

Revert "Middleware: Pass non-branch query parameters on redirect"#84
sirreal merged 1 commit intomasterfrom
revert-81-update/pass-query-params

Conversation

@sirreal
Copy link
Copy Markdown
Member

@sirreal sirreal commented Jan 12, 2019

Reverts #81

#81 did not work as expected. Redirections were happening as follows without ever booting a branch or arriving at desired sha URLs:

/?branch=master -> /?
/?branch=master&flags=jetpack/checklist -> /?flags=undefined

@sirreal sirreal merged commit 8167dca into master Jan 12, 2019
@sirreal sirreal deleted the revert-81-update/pass-query-params branch January 12, 2019 16:23
sirreal added a commit that referenced this pull request Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant