Middleware: Pass non-branch query parameters on redirect / take 2#85
Closed
Middleware: Pass non-branch query parameters on redirect / take 2#85
Conversation
blowery
reviewed
Feb 26, 2019
|
|
||
| const query = | ||
| Object.keys( req.query ) | ||
| .reduce( |
Contributor
There was a problem hiding this comment.
i think the querystring module will do this for you
Contributor
There was a problem hiding this comment.
https://nodejs.org/api/querystring.html#querystring_querystring_stringify_obj_sep_eq_options
i think you're removing the branch key and then serializing the remaining query?
Member
Author
There was a problem hiding this comment.
i think you're removing the
branchkey and then serializing the remaining query?
That was the intention, but it didn't work as expected. See the resulting redirections from #84:
/?branch=master->/?/?branch=master&flags=jetpack/checklist->/?flags=undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#81 second attempt after revert in #84
cc: @dmsnell