feat(harper-ls): add configurable diagnostic delay - #3282
Conversation
|
It looks like you've broken some VS Code tests. You might want to try extending their timeouts to account for the default delay. It might be an easy fix. |
d148093 to
f9b9a32
Compare
437bcf8 to
88ce2e2
Compare
|
@Dronakurl, have you read our agent policy? |
|
Thank you for pointing that out to me. I have read it now. :-) So here is the brief, non LLM-generated description of the state of the PR:
I am not an experienced rust programmer, to be honest, but I looked at the code myself and found it reasonable (unlike this other language feature, which should not have been marked "ready for review" in the first place). Could you please have a brief look at the code and tell me the first thing you find problematic? (The first thing in the changed files is this "pr_drafts" folder, which should not be in there, so maybe the second thing. :-)) |
9f3b7a4 to
fde4cd4
Compare
fde4cd4 to
e2afb11
Compare
|
Updated the PR description, since it was only AI stuff, so now I would be grateful for a review on this PR. @elijah-potter |
219b66e to
b3c67e3
Compare
d6a966c to
3f19c51
Compare
d1339af to
849b909
Compare
elijah-potter
left a comment
There was a problem hiding this comment.
This looks great! It is well-written, maintainable code. Thank you!
Keep delayed diagnostics simple and bug-focused by debouncing didChange publishes, cleaning up pending task state, and removing the race-prone post-code-action refresh path. before getting rid of the generation now generation pending_diagnostic_task move publish_immediately get rid of the test
849b909 to
5aa2450
Compare
|
Thank you for the review. I got a message that there were problems merging this, so I rebased onto the master. No other changes and no merge conflicts. |
…-in-normal-mode # Conflicts: # harper-ls/Cargo.toml
feat(harper-ls): Add configurable diagnostic delay
This PR is now hand written. I took the code generated by vibe and stripped it down. In the end, I basically touched every line.