fix: allow lowercase mp3 after an - #3369
Merged
elijah-potter merged 2 commits intoJun 29, 2026
Merged
Conversation
hippietrail
requested changes
May 13, 2026
hippietrail
left a comment
hippietrail
left a comment
Collaborator
There was a problem hiding this comment.
Looks good but add a comment please.
|
|
||
| if matches!(word, ['m', 'p', digit, ..] if digit.is_ascii_digit()) { | ||
| return Some(InitialSound::Vowel); | ||
| } |
Collaborator
There was a problem hiding this comment.
I think this is fine for now as uppercase MP3 is already handled in the acronyms section and mp-3 and mp 3 are way less common that mp3. We can extend this if we find other "lowercase initialisms".
I think it's different enough from the other match arms here to warrant a comment though.
hippietrail
approved these changes
May 13, 2026
hippietrail
left a comment
hippietrail
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me now. Thanks.
elijah-potter
approved these changes
May 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
May 27, 2026
Collaborator
|
See also: #3531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mpfollowed by a digit (for example,mp3) as beginning with the vowel sound "em" for indefinite-article linting.an mp3anda mp3.Fixes #3289.
Verification
cargo test -p harper-core linting::an_a -- --nocapturegit diff --check