Skip to content

Fixes three false positives when "A" or "B" are school test grades - #3718

Merged
hippietrail merged 3 commits into
Automattic:masterfrom
hippietrail:school-grades-3715
Jun 25, 2026
Merged

Fixes three false positives when "A" or "B" are school test grades#3718
hippietrail merged 3 commits into
Automattic:masterfrom
hippietrail:school-grades-3715

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

Fixes #3715

Description

There were two false positives when "A" was a school test grade and one where "B" was a school test grade.

The AnA linter now aborts if an "A" is uppercase and either:

  • preceded by "an" or "a"
  • Followed by - then another capital letter between "B" and "F"

The ExpandMemoryShorthands linter now aborts if "b" is followed by "+" or "-"

How Has This Been Tested?

cargo test 3715 then full cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail
hippietrail enabled auto-merge June 25, 2026 08:38
@hippietrail
hippietrail added this pull request to the merge queue Jun 25, 2026
Merged via the queue into Automattic:master with commit c3dc82c Jun 25, 2026
12 checks passed
@hippietrail
hippietrail deleted the school-grades-3715 branch June 25, 2026 09:26
elijah-potter pushed a commit that referenced this pull request Jun 29, 2026
…3718)

* test: added tests for #3715

* fix: false positives in issue 3715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Various false positives in text about school grades

1 participant