feat: have ways to go → have a ways to go - #3810
Merged
Merged
Conversation
Includes a new `find_the_only_token_index_matching()` Includes silencing all the new warnings though they're unrelated.
…_only_token_matching()`
hippietrail
enabled auto-merge
July 22, 2026 07:17
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2026
elijah-potter
pushed a commit
that referenced
this pull request
Jul 28, 2026
* feat: have ways to go → have a ways to go Includes a new `find_the_only_token_index_matching()` Includes silencing all the new warnings though they're unrelated. * refactor: DRY out `find_the_only_token_index_matching()` vs `find_the_only_token_matching()` * fix: the new errors clippy doesn't mention but cause CI to fail * fix: more CI-only errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
Some people hypercorrect the idiom "a ways to go" by removing the indefinite article which would seem to conflict with the plural noun "ways".
The linter handles all the false positives I could identify. It requires either the word "still" before "ways to go", or a few words or phrases that seem to occur only with the idiom and not literal texts about multiple paths to take.
Includes a new
find_the_only_token_index_matching()method onExprLinterso we can useInsertAfterrather than implementInsertBefore.(Also includes silencing all the new warnings though they're unrelated.)
How Has This Been Tested?
cargo testAI Disclosure
I asked Google Search AI for refactoring help as well as my editor's AI.
If Your PR Implements or Enhances a Linter
Checklist