feat(chrome-ext): inline HN page for testing - #3825
Merged
Merged
Conversation
elijah-potter
enabled auto-merge
July 15, 2026 14:27
elijah-potter
added a commit
that referenced
this pull request
Jul 28, 2026
* feat(chrome-ext): inline HN page for testing * fix(chrome-ext): update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fact that the HN page we tested the Chrome Extension against needed to be grabbed from the network resulted in slow, flaky tests.
I have inlined it into a page, so it never changes and it never goes down.
How Has This Been Tested?
I ran the tests.
AI Disclosure
Checklist