Skip to content

fix: dictionary had // comments instead of # - #3905

Merged
hippietrail merged 1 commit into
Automattic:masterfrom
hippietrail:dictionary-bad-comments
Jul 28, 2026
Merged

fix: dictionary had // comments instead of ##3905
hippietrail merged 1 commit into
Automattic:masterfrom
hippietrail:dictionary-bad-comments

Conversation

@hippietrail

Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

While testing #3323 I discovered "deal-breaker" was generating several spurious derived forms such as "dedeal-breaker" - it turned out three lines had C++ style comments instead of the correct # comments and the // comments tricked the dictionary+annotation parsing logic to treat it like a separator between the base word and the annotation flags.

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail
hippietrail enabled auto-merge July 28, 2026 13:53
@hippietrail
hippietrail added this pull request to the merge queue Jul 28, 2026
Merged via the queue into Automattic:master with commit 3cbf103 Jul 28, 2026
12 checks passed
@hippietrail
hippietrail deleted the dictionary-bad-comments branch July 28, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant