feat: flag plural nouns followed by seems - #3989
Open
ColumbusLabs wants to merge 1 commit into
Open
Conversation
ColumbusLabs
marked this pull request as ready for review
August 9, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3285.
Description
Adds a focused agreement rule for unambiguously plural common nouns followed by
seems, replacing the verb withseemwhile preserving its case.The rule is intentionally conservative around prepositional phrases, coordinated noun lists, mass nouns, proper nouns, and singular/plural-invariant nouns to avoid default-enabled false positives. It validates regular and curated irregular plural forms before reporting.
Demo
Web pages seems to work pretty well so far.is reported asPluralNounSeemswith the correctionWeb pages seem to work pretty well so far.How Has This Been Tested?
cargo test -p harper-core plural_noun_seems -- --nocapture(19 passed)just test-rust(6,107 passed, 290 ignored, 0 failed inharper-core; all workspace tests and doctests passed)just formatcargo fmt --all -- --checkgit diff --checkcargo run --bin harper-cli --release -- lint 'Web pages seems to work pretty well so far.'just check-rustwas also attempted. It reached the workspace Clippy pass but is currently blocked on existingharper-desktop/src-tauri/src/mac_broker/mod.rs:34(Configis an unused import under-D warnings), outside this change.AI Disclosure
If Your PR Implements or Enhances a Linter
Checklist