feat: Flag "discuss about" instead of "discuss"#645
Merged
Conversation
This is very common in Indian English but I've heard it in Euroenglish as well. Examples from GitHub: - Hi, Today after 3 hours, I'm at live YouTube Podcast, **discussing about** Meteor 3 at small devices like Raspberry Pi. - this repository **discusses about** core concepts in react Unfortunately there seem to be rare false positives: - However, I think that raises some similar challenges to what I **discussed about** option 1 above: it creates a pressure to organize the configuration in a way ... But this sounds wrong in other ways anyway. Better would be "discussed in", "mentioned in", "covered in"...
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 25, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.20.0` -> `v0.22.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.22.0`](https://github.com/Automattic/harper/releases/tag/v0.22.0) [Compare Source](Automattic/harper@v0.21.1...v0.22.0) #### What's Changed - feat(core): create hyphenation rule for `out-of-date` by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#671 - chore: use `just sampleforms` to fix curated dict entries by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#660 - fix: change "and alike" phrase correction to "and the like" by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#705 - Add Automattic Lingo and Branding by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#706 - fix(core): possesive -> possessive typo in lint message by [@​b-sharman](https://github.com/b-sharman) in Automattic/harper#690 - build(deps): bump smallvec from 1.13.2 to 1.14.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#694 - build(deps-dev): bump [@​types/node](https://github.com/types/node) from 22.13.1 to 22.13.4 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#698 - build(deps-dev): bump jasmine and [@​types/jasmine](https://github.com/types/jasmine) in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#696 - build(deps): bump clap from 4.5.28 to 4.5.29 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#695 - build(deps-dev): bump vite-plugin-top-level-await from 1.4.4 to 1.5.0 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#699 - build(deps-dev): bump [@​sveltejs/adapter-node](https://github.com/sveltejs/adapter-node) from 3.0.3 to 5.2.12 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#700 - build(deps-dev): bump flowbite from 3.1.1 to 3.1.2 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#697 - feat(harper.js): allow modification to the dictionary. by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#683 - fix(core): `someways` is not a noun by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#708 - fix(core): make `ChangeTack` lint more specific by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#709 #### New Contributors - [@​b-sharman](https://github.com/b-sharman) made their first contribution in Automattic/harper#690 **Full Changelog**: Automattic/harper@v0.21.1...v0.22.0 ### [`v0.21.1`](https://github.com/Automattic/harper/releases/tag/v0.21.1) [Compare Source](Automattic/harper@v0.20.0...v0.21.1) #### What's Changed - Proper noun caps australia by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#651 - feat: Flag "discuss about" instead of "discuss" by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#645 - feat: suggestion to change "sooner than later" by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#644 - feat: proper noun capitalization for Malaysia by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#652 - Implements [#​505](Automattic/harper#505) could of, should of, would of -> ... have by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#647 - Remove Duplicate Spelling Suggestions by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#654 - feat(core): condense `further more` by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#655 - feat: rename `FullDictionary` -> `MutableDictionary` and add some doc comments by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#658 - chore: fixes to curated dictionary affixes by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#650 - build(deps): bump once_cell from 1.20.2 to 1.20.3 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#634 - feat: add some words to curated dictionary by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#596 - feat(web): make underlines animate into existence on page load by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#664 - Chock full by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#666 - Several New Linters by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#663 - feat: multi-word proper nouns for Canada by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#657 - fix(core): edge cases in the closed compound noun rule by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#670 - docs: add nixpkgs as an installation method by [@​sumnerevans](https://github.com/sumnerevans) in Automattic/harper#656 #### New Contributors - [@​sumnerevans](https://github.com/sumnerevans) made their first contribution in Automattic/harper#656 **Full Changelog**: Automattic/harper@v0.20.0...v0.21.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjkuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is very common in Indian English but I've heard it in Euroenglish as well.
Examples from GitHub:
Unfortunately there seem to be rare false positives:
But this sounds wrong in other ways anyway. Better would be "discussed in", "mentioned in", "covered in"...