Create linter for non-idiomatic "back in the days"#707
Merged
Conversation
elijah-potter
force-pushed
the
back-in-the-days
branch
from
60e06df to
56377c1
Compare
Also the unit tests from my version of this lint I was working on yesterday.
Collaborator
I was working on a linter for this one yesterday too and got stuck. I can see that new functionality was indeed needed. I also found another false positive with "Back in the days when ...". I submitted a PR with that change plus all my unit tests to this branch: #712 |
feat: another exception for "back in the days before"
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 26, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.22.0` -> `v0.23.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.23.0`](https://github.com/Automattic/harper/releases/tag/v0.23.0) [Compare Source](Automattic/harper@v0.22.0...v0.23.0) #### What's Changed - feat: another exception for "back in the days before" by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#712 - feat(core): allow the `ThenThan` linter to cover more cases by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#714 - Create linter for non-idiomatic "back in the days" by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#707 - Make `Lintkind::Spelling` exclusive to one rule. by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#713 - feat: github template for reporting false positives by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#728 - chore: dictionary curation by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#727 - Overhaul by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#726 - feat(core): added technical words to dictionary by [@​ficcdaf](https://github.com/ficcdaf) in Automattic/harper#729 - feat: lex 4-digit plural decades by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#675 - fix(core): edge case found in Harper's documentation by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#737 - fix(core): address edge cases in `ThenThan` rule by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#735 - feat(core): add rule that corrects `ban together` by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#734 - fix(vscode-plugin): update config keys to new standard by [@​mcecode](https://github.com/mcecode) in Automattic/harper#733 - feat: reimplement "operative system(s)" by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#719 - fix(core): restrict `GeneralCompoundNouns` to ignore adverb prefixes by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#736 - feat(core): added plural form of integration by [@​ficcdaf](https://github.com/ficcdaf) in Automattic/harper#740 - build(deps): bump typst-syntax from 0.12.0 to 0.13.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#757 - build(deps): bump anyhow from 1.0.95 to 1.0.96 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#758 - build(deps-dev): bump prettier from 3.4.2 to 3.5.2 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#763 - build(deps-dev): bump [@​vitest/browser](https://github.com/vitest/browser) from 3.0.5 to 3.0.6 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#762 - build(deps-dev): bump [@​rollup/plugin-node-resolve](https://github.com/rollup/plugin-node-resolve) from 15.3.1 to 16.0.0 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#764 - chore: dictionary curation by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#745 - feat: tests for sentences containing a decade by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#747 - feat(vscode-plugin): config updates by [@​mcecode](https://github.com/mcecode) in Automattic/harper#754 - fix(core): improper pattern by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#739 - doc(web): updated environment and language-server documentation on the website by [@​ficcdaf](https://github.com/ficcdaf) in Automattic/harper#741 - build(deps): bump serde from 1.0.217 to 1.0.218 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#760 - feat: add `just sample` to list all forms of random dictionary words by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#646 - build(deps): bump ordered-float from 4.6.0 to 5.0.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#759 - build(deps-dev): bump [@​microsoft/api-documenter](https://github.com/microsoft/api-documenter) from 7.26.7 to 7.26.10 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#765 - feat: capitalize multi-word country and capital city names by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#703 - Fuzz results by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#773 - feat: move 'could of' etc from `matcher.rs` to its own linter by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#715 - fix: better ascii and hex digit checks by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#776 - build(deps-dev): bump [@​microsoft/api-extractor](https://github.com/microsoft/api-extractor) from 7.49.2 to 7.50.1 in /packages by [@​dependabot](https://github.com/dependabot) in Automattic/harper#761 - fix: mostly `j` annotations for adverbs in `-ly` by [@​hippietrail](https://github.com/hippietrail) in Automattic/harper#778 #### New Contributors - [@​ficcdaf](https://github.com/ficcdaf) made their first contribution in Automattic/harper#729 **Full Changelog**: Automattic/harper@v0.22.0...v0.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODAuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE4MC4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve #702.
Two things happened here.
PatternLintertrait to allow cancelling a lint in thematch_lintphase by returningOption::None.