Skip to content

Fix: When footer is not enabled, avoid JS errors #15365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Fix: When footer is not enabled, avoid JS errors #15365

merged 1 commit into from
Apr 9, 2020

Conversation

@dero
Copy link
Contributor

@dero dero commented Apr 8, 2020

Fixes #15348

Changes proposed in this Pull Request:

  • Makes explicit checks for the existence of footer and the blog title element within in order to not initialize any logic that depend on footer being present on the page.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is a fix that applies to the Infinite Scroll module.

Testing instructions:

Proposed changelog entry for your changes:

  • Fixes an Infinite Scroll bug that prevented its functionality on themes without footers.

@dero dero requested a review from a team April 8, 2020 08:22
@dero dero self-assigned this Apr 8, 2020
@jetpackbot
Copy link
Collaborator

jetpackbot commented Apr 8, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 5, 2020.
Scheduled code freeze: April 28, 2020

Generated by 🚫 dangerJS against 3b0542d

@jeherve jeherve added this to the 8.4.2 milestone Apr 8, 2020
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Apr 8, 2020
jeherve
jeherve requested changes Apr 8, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase now that #15366 is merged? That should fix the tests. Thanks!

@dero dero force-pushed the fix/infinite-scroll-footer-issue branch from 87797c1 to 3b0542d Compare April 8, 2020 13:07
@dero
Copy link
Contributor Author

dero commented Apr 8, 2020

@jeherve Done.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello dero! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D41577-code before merging this PR. Thank you!

jeherve
jeherve approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to test well for me. Leaving it for a second review too.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 8, 2020
@jeherve jeherve merged commit 07162c6 into master Apr 9, 2020
@jeherve jeherve deleted the fix/infinite-scroll-footer-issue branch April 9, 2020 12:47
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 9, 2020
jeherve pushed a commit that referenced this pull request Apr 9, 2020
@dero @jeherve
[not verified] Fix: When footer is not enabled, avoid JS errors (#15365)
5ed2d6d
@jeherve
Copy link
Member

jeherve commented Apr 9, 2020

Cherry-picked to branch-8.4 in 5ed2d6d

jeherve added a commit that referenced this pull request Apr 9, 2020
@jeherve
8.4.2 changelog: add #15365
0e5ae04
jeherve added a commit that referenced this pull request Apr 14, 2020
@jeherve
8.4.2: changelog (#15393)
35d8b21 
* 8.4.2 changelog: add #15365

* [not verified] Changelog: add #15372

* Changelog: add #15368

* Changelog: add #15395

* Changelog: add #15396

* Changelog: add #15406
jeherve added a commit that referenced this pull request Apr 14, 2020
@jeherve
[not verified] 8.4.2: changelog (#15393)
3ef358e 
* 8.4.2 changelog: add #15365

* [not verified] Changelog: add #15372

* Changelog: add #15368

* Changelog: add #15395

* Changelog: add #15396

* Changelog: add #15406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@dero dero

Labels

[Feature] Infinite Scroll Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

8.4.2

Development

Successfully merging this pull request may close these issues.

Infinite Scroll: broken when footer is set to false

6 participants

@dero @jetpackbot @matticbot @jeherve @kraftbj