Skip to content

Conversation

@dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Dec 2, 2025

Fixes an issue introduced when updating the dataviews package, where the column spacing is broken
Update PR: #45914

Proposed changes:

  • Sets the "from" field as the title field, marking it as primary

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Without updating the dataviews package, go to the dashboard
  • Check that the "from" column still works as before, the only change is the bold style on the text
  • Checkout the PR linked above, updating the dataviews package, pnpm install and restart watch build
  • Check that there is a big gap after the checkbox in the dashboard
  • Apply this code on top of the linked PR
  • Check that the gap is fixed, with the "from" field taking the available space
Before After
Screenshot from 2025-12-02 17-41-46 Screenshot from 2025-12-02 17-42-40

@dhasilva dhasilva requested a review from a team December 2, 2025 20:43
@dhasilva dhasilva self-assigned this Dec 2, 2025
@dhasilva dhasilva added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-dashboard-primary-field branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/forms-dashboard-primary-field

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

.jp-forms__inbox__author-field__email {
font-size: 11px;
filter: opacity(0.8);
filter: opacity(0.6);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the reduction in opacity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because by changing the field to a titleField the color and weight are changed automatically as well. With the darker color, the 0.8 opacity looks too dark for the secondary information, so I reduced it to 0.6 to account for that.
You can test it in the browser to see the difference, I think you'll agree.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this make sense to make! Nice touch 💅

@enejb
Copy link
Member

enejb commented Dec 2, 2025

Nice fix @dhasilva!

Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@dhasilva dhasilva merged commit 7d364bf into trunk Dec 2, 2025
74 checks passed
@dhasilva dhasilva deleted the fix/forms-dashboard-primary-field branch December 2, 2025 21:45
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Package] Forms [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants