Conversation
Closed
Contributor
|
Looks good to me! I'm going to go ahead and merge with two notes: I spoke with @darthhexx yesterday, and he stressed the importance of tests covering the php<->js and back because the php does additional processing on the image, so it'd be great if we could add those. Having said that, it's not an either/or scenario, and these tests still seem valuable on their own merit, so I'm going to go ahead and merge this PR into master (we can always revert later if we need to). The other thing is that I'm still a bit scarred from maintaining tests with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR proposes a few tests for the
snapshot.jsfile. This will hopefully make the development process a little safer and more rigorous.Once this PR is approved, or more tests are suggested, we could then send minor patches such as #16 without less risk on affecting the service stability.
Soon, after this, I'll add a failing test for #16, then I'll send a patch to make it pass.
Thanks!