Conversation
Contributor
Author
|
Reopening - I closed the wrong PR by mistake |
Member
|
How come this is adding new files instead of modifying the test files? Does this need rebase? |
deBhal
pushed a commit
that referenced
this pull request
Mar 17, 2021
deBhal
pushed a commit
that referenced
this pull request
Mar 17, 2021
deBhal
pushed a commit
that referenced
this pull request
Mar 18, 2021
deBhal
added a commit
that referenced
this pull request
Mar 23, 2021
* Attempt to run mshots in a local development environment via Docker * memcache_connect() is part of the memcache extension, not memcached (yes, this is confusing) * Add a docker-compose file, and launch a memcached server with it * some Dockerfile comments * add the GD extension * Try/run mshots from local docker env local edit (#26) * Docker: Add docker volume so that you can edit the files locally * Fix memcache This part is untesed in production. I am not sure what port is used there. * Specify compatible version of memcache memcache 8.0 requires php 8.x, so we need to use a version compatible with our php7.4 ( https://pecl.php.net/package/memcache ) * add .dockerignore * typo * Share dev local dev filesystem with container * Add MSHOTS_MEMCACHE_HOST environment variable to control memcache server inside container * update package-lock.json * build container successfully if the requested user already exists * Support "simple" docker container alongside shared local filesystem version using `npm run config:dev` command * Add note about replacement mshots_ctl.sh stop * Add docker image prune to troubleshooting * separate concerns better in package.json scripts * Remove docker-compose.yml from git so it doesn't show up in git diffs * fix npm start script * Enable chromium sandbox outside a container * remove unnecessary directory limitation Co-authored-by: Julian de Bhal <julian.debhal@automattic.com> * add generated docker-compose.yml to .gitignore * Move changable data down the Dockerfile to enable more caching * Add note about output to README * Improve consistency in `npm run config:*` * add npm run restart * add a couple more start/stop npm scripts * Add phpunit tests * Add screen dimensions unit test * Support screenWidth and screenHeight params * Match viewport limits with screen limits * Give GitHub actions more time to screenshot * Minor cleanup * Only add viewport params when needed * whitespace * Cap length at clientHeight for new requests * remove deconstructing assignment because it hangs in the container * Add maximum screen size and increase thumb limit to that * Use document.documentElement.scrollHeight & width instead of body.clientHeight and width https://stackoverflow.com/questions/21064101/understanding-offsetwidth-clientwidth-scrollwidth-and-height-respectively * fix variable names (clientX -> documentX) * Cherry pick async code from PR #20 * Add note about docker permissions to mount directory * Add "Mounts denied" to troubleshooting * Fix mention of output directory * Add a note about expected mShots redirect to default image * add vim to the image for convenience * Apache: AllowEncodedSlashes On * Reduce workers to 2 in dev setup * Return http response code 200 * Fix dev-override typo * rename env variable WORKERS to MSHOTS_WORKERS Co-authored-by: Andrew Serong <andrewserong@users.noreply.github.com> Co-authored-by: Yoav Farhi <yoav@farhi.org> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com> Co-authored-by: Omar Alshaker <omar@omaralshaker.com>
Contributor
Author
|
Closing: This PR was included in #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #17 to remove the need for sleeps.
It turns out that this only reduces the run time by a couple of seconds (~15 -> ~13) for these tests, so not a huge priority, but it should still make them more reliable.