Ship 2.0.0

[zbjornson]

What do you guys think, is it time finally?

• No known regressions.
• Complete docs present for upgrading from v1.x.
• All open PRs are semver minor/patch, except Linus' Add support for WebP decoding #1280, which I think should be 3.x because it drops Node.js 6.x support.
• Five possible semver-major issues open, but none have activity and another semver-major release can come in the near future.
• Prebuilds are working fairly smoothly. The largest improvement would probably come from uploading the binaries in the npm tarball itself, but the builds are too large right now. Using N-API so we have a stable ABI would require Node.js 10 for non-experimental support. I think the dependencies could be deduped between ABI builds though (should only need one per platform).

Closes #743
Closes #916

[LinusU]

except Linus' #1280, which I think should be 3.x because it drops Node.js 6.x support.

👍

Five possible semver-major issues open, but none have activity and another semver-major release can come in the near future.

I've actually addressed one of them as a side effect in #1280, in that PR all loading is async

Prebuilds are working fairly smoothly.

👍

---

Let's do this! I'm ready to cut a release whenever, should we sync up so that we can get the prebuilt packages done just after?

ping @chearon

Actually, I'll merge and release this, but keep it under the next tag on npm until we get the prebuilds out. Then we can just update the latest tag to point at 2.0.0 as well, and all users will start getting that version.

Thanks everyone for all of the great help building 2.x, it's really been amazing! ❤️ 🚀 🎉

[LinusU]

Just realized that I maybe was a bit quick in merging this, just got so excited ☺️

I haven't put this under the latest tag on npm yet, so feel free to chime in with any feedback, it's not too late to change things. If anyone felt that they didn't get enough time to comment I'm really sorry about that 🙈

[asturur]

give me time to read the next major breaking PRs, please, if one of them is fabricJS related i could consider doing a deep dive.

From alpha to release without beta and rc, i was not prepared yet

[asturur]

All the semver major open issues looks like not so important from a functionality stand point ( TO ME ).

I have 2 questions:

why adding ctx.filter should be a major break?

also

How we are with fonts? can we actually define 2 fonts file, with the same family but different bold/italic style and having it working? this is important for me and i available to make it work if possible

[zbjornson]

I've actually addressed one of them as a side effect in #1280, in that PR all loading is async

@LinusU I was going to ask if you wanted to pull out the nice refactoring you did in #1280, separate from WebP support.

---

@asturur :

why adding ctx.filter should be a major break?

We use ctx.filter currently for setting quality of some operations. Since that was added (years ago), a standard property with the same name was added: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/filter. We need to rename our filter property. We could do that quickly now.

can we actually define 2 fonts file, with the same family but different bold/italic style and having it working?

I believe so. The API allows it, and I think the upstream pango bug that caused incorrect font selection was fixed with @chearon's patch.

BTW, since fabric uses jsdom: I have a jsdom PR open already. I need to update it a bit, but jsdom's package.json is set to use 1.x (not "latest"), so publishing 2.x won't break jsdom immediately.

---

I just closed my proposed #934 (see reason there).

[asturur]

i would ask to use this major release to rename .filter in .somethingElse and leave open for implementing filters ( hardly someone will do that ) with a minor patch.

[asturur]

BTW, since fabric uses jsdom: I have a jsdom PR open already. I need to update it a bit, but jsdom's package.json is set to use 1.x (not "latest"), so publishing 2.x won't break jsdom immediately.

I know about this PR, i think i was also in the PR asking to backport to 9.12 that was last node 4 working version of jsdom. Since node 4 is officially out, i ll probably update to fabric 3.0 dropping node4 so i can switch to all the new stack.

[asturur]

Is also unclear to me where is the connection between fonts in jsdom and node-canvas and if this is something that should be added.

Other question: Is svg supported out of the box? or prebuilt binaries still do not support it?

[chearon]

ping @chearon

On it! When the binaries are all listed here you can update the tag.

Other question: Is svg supported out of the box? or prebuilt binaries still do not support it?

Just not on Windows right now: node-gfx/node-canvas-prebuilt#42. We can update the binaries retroactively if absolutely necessary.

[LinusU]

@chearon I've unpublished 2.0.0 and published 2.0.1, would you mind starting a new job for the prebuilds? Sorry about the mess 🙈

[chearon]

No worries, all done!

[LinusU]

We're live! 🎉 🌮 🚀

[asturur]

cannot wait to upgrade everything and finally have svg tests on node for fabricjs.

Also looking forward filling the gap on text position on scaled context.