pymsrc attribute fixes #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlk
approved these changes
Mar 11, 2017
Collaborator
|
Yep, looks like I botched the fix included in #13 when I made the merge commit: 0ed6a42#diff-c4e135a8ae2df878e74ea4ca3ca1cbc3R42 Thanks for this pull request, and for catching the Notice. |
benlk
added a commit
that referenced
this pull request
Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why, but the
pymsrctypo reappeared in fcb15b4. This fixes that again. This also checks if the attribute is empty. Otherwise, you get aNotice: Undefined index: pymsrcwarning if there are multiple Pym shortcodes on a single page.