Skip to content

Open checks in the middle panel#196

Merged
jorgefilipecosta merged 2 commits into
trunkfrom
open-check-in-middle-panel
May 20, 2026
Merged

Open checks in the middle panel#196
jorgefilipecosta merged 2 commits into
trunkfrom
open-check-in-middle-panel

Conversation

@tyxla
Copy link
Copy Markdown
Member

@tyxla tyxla commented May 20, 2026

Summary

Addresses the remaining bullets from #184 — selecting a check should open it in the middle panel like any other resource.

  • Clicking a check row in the project view opens it in the middle panel via the same routing drafts use (App.handlePreviewFile → handleOpenDraftEditor).
  • The per-row checkbox and the edit icon are both gone from the project view — the row click is the edit affordance, so the icon would just duplicate it. Delete (trash) stays.
  • While a check is open in the middle, the right sidebar mirrors the project view: only chat + checks tabs (no outline / share), the checks panel drops the Run button, and rows render without the enable/disable checkbox and without the edit icon. Clicking another check in the sidebar swaps the middle window (no inline sidebar editor).
  • The draft-editor sidebar (when editing a draft / done) is unchanged — it still has outline + share + the Run button + per-row checkbox + edit icon.
  • Removed the now-dead inline-editor wiring (renderCheckEditor, editingCheckRelPath, editingRelPath / renderEditor) from DraftEditorScreen, DraftSidebar, DraftChecksPanel, and useProjectChecks.

Closes #184.

Test plan

  • Run npm run test:e2e -- tests/e2e/project-checks.spec.ts — covers row-click open from project view, row-click swap from the right sidebar while a check is open in the middle, sidebar shape (no outline / share, no Run, no checkbox, no edit icon), and create / delete from project view.
  • Manual: open Checks tab in project view — rows show only title + delete (no checkbox, no edit icon). Click a row — opens in middle.
  • Manual: while a check is open, switch to the Checks tab in the right sidebar — only chat + checks tabs are visible, no Run button, rows have no checkbox or edit icon. Click another check — middle swaps to it.
  • Manual: regression — opening a draft (folder=drafts) still shows the full sidebar (chat + outline + checks + share) with the Run button, per-row checkbox, and edit icon in the checks panel.

🤖 Generated with Claude Code

@tyxla tyxla self-assigned this May 20, 2026
@tyxla tyxla added the enhancement New feature or request label May 20, 2026
tyxla and others added 2 commits May 20, 2026 16:19
Selecting a check from the project view's checks panel now opens it in
the middle panel via the same routing drafts use, and the edit icon does
the same. While a check is open in the middle, the right sidebar mirrors
project view — only the chat + checks tabs, with the checks panel
dropping the Run button and per-row checkbox so it reads as plain
project-scoped CRUD.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The edit icon is redundant when clicking the row already opens the
check in the middle. Hide it whenever the panel runs in
`onOpenCheck` mode (project view + the right sidebar while a check
is open in the middle). The draft-editor sidebar (editing a
draft/done) is unaffected and keeps the edit icon.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jorgefilipecosta jorgefilipecosta force-pushed the open-check-in-middle-panel branch from e083ec9 to edd1a5b Compare May 20, 2026 14:22
@jorgefilipecosta jorgefilipecosta merged commit 1808bd9 into trunk May 20, 2026
@jorgefilipecosta jorgefilipecosta deleted the open-check-in-middle-panel branch May 20, 2026 14:26
@oandregal
Copy link
Copy Markdown
Contributor

Thanks @tyxla

The only bit missing would be deletion: both bundled checks + user-provided checks.

The "delete" icon next to the check is not working as expected (it should work the same as removing the file from the three-dot menu at the top-right):

Screen.Recording.2026-05-20.at.16.30.17.mov

After removing a check, the checks panel should remain open.

@tyxla
Copy link
Copy Markdown
Member Author

tyxla commented May 20, 2026

The only bit missing would be deletion: both bundled checks + user-provided checks.

The "delete" icon next to the check is not working as expected (it should work the same as removing the file from the three-dot menu at the top-right):

After removing a check, the checks panel should remain open.

#206 should address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checks should be editable all the time in project view

3 participants