Conversation
📊 Performance Test ResultsComparing a9f88e4 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
|
Some tests were failing so I retriggered them while I am reviewing the PR |
katinthehatsite
left a comment
There was a problem hiding this comment.
The changes are straightforward and look good to me, I am not seeing any improvements to suggest.
Out of curiosity, what makes this switch beneficial?
From the original issue:
|
Related issues
How AI was used in this PR
AI assisted with identifying the API differences between
oraandpicospinnerand performing the migration across all affected files. All changes were reviewed and tested.Proposed Changes
ora(8 dependencies) withpicospinner(zero dependencies) for CLI spinnersLoggerclass inapps/cli/logger.tsto use picospinner'sSpinnerAPI:new Spinner(),.setText(),.running,.refresh(),.stop()apps/cli/vitest.setup.tsandapps/studio/vitest.setup.tsTesting Instructions
npm run cli:buildnode apps/cli/dist/cli/main.mjs site start <site-folder>and confirm the spinner animates and shows success/failure symbols correctlynode apps/cli/dist/cli/main.mjs site stop <site-folder>and confirm spinner stops cleanlysite pullandsite pushto verify progress percentage updates render in-placenpm testto confirm all 141 test files passPre-merge Checklist