CLI: Show clear error for non-existent WordPress versions#3065
CLI: Show clear error for non-existent WordPress versions#3065
Conversation
When a user specifies a non-existent WordPress version via --wp flag, the command now fails early with a clear error listing available versions instead of proceeding through all setup steps and failing with a generic server startup error.
Move the version availability check to the top of the handler so it fails immediately when --wp is passed with a non-existent version, instead of after the user fills in all interactive prompts.
📊 Performance Test ResultsComparing 8212553 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
|
The breaking unit tests seem unrelated to these changes, I pulled in trunk again to rerun them. |
| try { | ||
| const availableVersions = await fetchWordPressVersions(); | ||
| const isAvailable = availableVersions.some( | ||
| ( v ) => v.value === wpVersion || v.value.startsWith( wpVersion + '.' ) |
There was a problem hiding this comment.
Instead of just validating that a matching version exists, should we resolve wpVersion to the matched full version? For example, --wp 6.7 actually downloads 6.7.2 instead of 6.7.0.
There was a problem hiding this comment.
It seems Playground already handles this and resolves to the latest patch, so feel free to disregard.
The behavior is still somewhat obscure based on Playground behavior, up to you if you feel it makes sense to handle it here or leave as is.
There was a problem hiding this comment.
Thanks for the suggestion! I think it's still valuable to add the resolution here, and maybe also add a log message to clarify the resolution if short versions are provided.
When --wp flag specifies a non-existent version, show a clear error listing available versions instead of failing with a generic server error. Short versions like "6.7" are resolved to full versions like "6.7.2" with a log message showing the resolution.
picospinner requires the spinner to be running for fail/succeed to render output. Start it with a "Checking WordPress version" message before fetching available versions.
…i-wp-version-error
3 participants
Related issues
Fixes STU-1556
How AI was used in this PR
AI-assisted implementation and testing. All changes reviewed manually.
Proposed Changes
When creating a site with
studio site create --wp 8.2, the version passes format validation and the minimum version check, but the version doesn't actually exist. The CLI proceeds through all setup steps (directory creation, SQLite, port assignment) then fails with a generic "Failed to start WordPress server: WordPress server process exited unexpectedly" with no indication the version itself is the problem.--wpversion against the list of available WordPress versions fetched from the WordPress.org API (the same list already used for the interactive version picker)6.7matches6.7.2)latestandnightly, and gracefully degrade if the API is unreachableTesting Instructions
npm run cli:buildnode apps/cli/dist/cli/main.mjs site create --wp 8.2WordPress version "8.2" is not available. Available versions: nightly, 6.7.2, 6.6.5, ...node apps/cli/dist/cli/main.mjs site create --wp 6.7and verify it works normallynode apps/cli/dist/cli/main.mjs site create(interactive) and verify it works normallyUsing short versions:
Pre-merge Checklist