Show the What's New announcements in the agentic UI - #4414
Draft
bcotrim wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude wrote the code and I reviewed it. Worth a careful look at the shared
lastSeenVersionwiring (both UIs now read and write the same marker) and at the constant-height grid in the guide modal.Proposed Changes
The "What's New" announcements now appear in the agentic UI, reusing the orientation guide's modal from #4331 instead of a second paged component.
Both UIs are driven by the same switch and the same stored marker: flipping
FORCE_SHOW_WHATS_NEWshows the announcements in whichever UI you're running, and dismissing them in one settles it for the other. Nothing about the classic renderer's behaviour changes.A first-run user gets the orientation guide only — the announcements record themselves as seen without showing, so nobody meets two modals in a row. Classic already worked this way.
Two fixes to the shared modal, both visible in #4331's guide too: the dialog focused "Learn more" instead of the advance button, so Enter opened the docs rather than paging; and the modal resized as you advanced, which it no longer does — every page renders in one grid cell, so the height comes from the longest page and stays put across translations.
The five illustrations move to
packages/commonso both UIs render the same artwork rather than duplicating ~275 KB of SVG.Testing Instructions
Agentic UI:
npm run cli:build:ui && node apps/cli/dist/cli/main.mjs ui --no-open, open http://localhost:8081localStorage.setItem('studio-onboarding-hints', JSON.stringify({tourCompletedVersion: 2}))andlocalStorage.removeItem('studio-whats-new-last-seen-version'), then reload — the guide opens after ~0.5sstudio-onboarding-hintsentirely and reload — you get the orientation guide only, and the announcements mark themselves seenDesktop (needs
npm start):Pre-merge Checklist