Kotlin: Add interceptors support to DefaultHttpClient and WpRequestExecutor
#1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow OkHttp interceptors to be passed to DefaultHttpClient while preserving hostname verification functionality. Add a convenience constructor to WpRequestExecutor that accepts interceptors directly. This enables clients to inject interceptors (e.g., for network debugging) without needing to manage OkHttpClient configuration. Changes: - Add `interceptors` parameter to `DefaultHttpClient` - Refactor to use `buildClient()` method for client construction - Add convenience constructor to `WpRequestExecutor`
Remove default values for interceptors throughout the client chain, requiring consumers to explicitly pass interceptors (even if empty). This makes the API more intentional and prevents silent defaults. Changes: - Fix initialization order bug in `DefaultHttpClient` (allowedHostnames before client) - Remove default `interceptors` parameter from `DefaultHttpClient` - Remove default `httpClient`/`requestExecutor` from all API clients - Add convenience constructors accepting `List<Interceptor>` to all clients - Update all call sites to pass `emptyList()` explicitly
oguzkocer
force-pushed
the
flexible-ok-http-builder
branch
from
021dea0 to
aa9ec22
Compare
The custom WpRequestExecutorHostnameVerifier doesn't handle wildcards or SANs like the default OkHttp verifier. Only apply it when there are actually allowed hostname overrides configured.
jkmassel
approved these changes
Nov 26, 2025
oguzkocer
added a commit
to wordpress-mobile/WordPress-Android
that referenced
this pull request
Nov 27, 2025
Pass empty interceptors list to API client constructors following the addition of interceptors support in wordpress-rs. Automattic/wordpress-rs#1041 Changes: - Update `WpApiClient`, `WpLoginClient`, and `WpRequestExecutor` calls to include `interceptors = emptyList()` - Bump wordpress-rs version in libs.versions.toml
oguzkocer
added a commit
to wordpress-mobile/WordPress-Android
that referenced
this pull request
Nov 27, 2025
Pass empty interceptors list to API client constructors following the addition of interceptors support in wordpress-rs. Automattic/wordpress-rs#1041 Changes: - Update `WpApiClient`, `WpLoginClient`, and `WpRequestExecutor` calls to include `interceptors = emptyList()` - Bump wordpress-rs version in libs.versions.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
OkHttpinterceptors to be passed toDefaultHttpClientwhile preserving hostname verification functionality. Add a convenience constructor toWpRequestExecutorthat accepts interceptors directly.This enables clients to inject interceptors (e.g., for network debugging) without needing to manage
OkHttpClientconfiguration.Changes:
interceptorsparameter toDefaultHttpClientbuildClient()method for client constructionWpRequestExecutorPart of CMM-998