Fix canceled preview queue requests - #2237
Merged
Merged
Conversation
AI assistance: OpenAI gpt-5.6-sol via OpenCode traced the queue lifecycle, implemented the initial fix and regression, and assisted with deterministic review refinements. Chris Huber reviewed and remains responsible for the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2235.
The serialized preview proxy queue now observes queued client cancellation. A canceled pending request is removed and resolved before it can invoke its upstream task. Active aborted requests destroy their upstream request/response streams and release the queue slot.
The regression contract holds the first request open, aborts a queued second request, then sends a third request. It asserts that the target receives only
/firstand/third, proving the canceled queued request never opens an upstream connection.Verification
npm run test:browser-callback-materialization-contractspassed twice after restoring the local generated runtime-core build output.node ./node_modules/typescript/bin/tsc -p packages/runtime-playground --noEmitpassed.git diff --checkpassed.git diffandgit status --shortare clean.AI Assistance
OpenAI gpt-5.6-sol via OpenCode traced the queue lifecycle, implemented the initial fix and deterministic regression, and assisted with review and verification. Chris Huber reviewed and remains responsible for the change.