Add omitted Shopping tests to CI filters - #173
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Restores full CI coverage for the Contoso Shopping sample by adding two previously omitted Shopping test projects back into the repository’s sample build/test solution filters.
Changes:
- Add
Contoso.Shopping.Test.UnitandContoso.Shopping.Test.SubscribetoCoreEx.Samples.Test.slnf. - Add
Contoso.Shopping.Test.UnitandContoso.Shopping.Test.SubscribetoCoreEx.Samples.Build.slnf.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CoreEx.Samples.Test.slnf | Includes Shopping unit + subscriber test projects in the test solution filter so PR CI runs them. |
| CoreEx.Samples.Build.slnf | Includes Shopping unit + subscriber test projects in the build solution filter so PR CI builds them. |
timbarreto
force-pushed
the
fm/coreex-all-tests-opus5
branch
2 times, most recently
from
July 24, 2026 21:59
9dda1ec to
8c33060
Compare
Signed-off-by: Tim Barreto <timbarreto@users.noreply.github.com>
timbarreto
force-pushed
the
fm/coreex-all-tests-opus5
branch
from
July 24, 2026 22:11
8c33060 to
1702fa8
Compare
chullybun
approved these changes
Jul 25, 2026
chullybun
left a comment
Collaborator
There was a problem hiding this comment.
Good pick up. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contoso.Shopping.Test.UnitandContoso.Shopping.Test.Subscribeto the sample build and test solution filtersValidation
dotnet build CoreEx.Samples.Build.slnf --no-restore --configuration Release— succeeded with 0 warnings and 0 errorsContoso.Shopping.Test.Unit— 48 passed across net8.0, net9.0, and net10.0Contoso.Shopping.Test.Subscribe— 15 passed across net8.0, net9.0, and net10.0