Skip to content

Add omitted Shopping tests to CI filters - #173

Merged
chullybun merged 1 commit into
Avanade:mainfrom
timbarreto:fm/coreex-all-tests-opus5
Jul 25, 2026
Merged

Add omitted Shopping tests to CI filters#173
chullybun merged 1 commit into
Avanade:mainfrom
timbarreto:fm/coreex-all-tests-opus5

Conversation

@timbarreto

Copy link
Copy Markdown
Contributor

Summary

  • add Contoso.Shopping.Test.Unit and Contoso.Shopping.Test.Subscribe to the sample build and test solution filters
  • restore pull-request CI coverage for two previously passing Shopping suites that were omitted from both filters

Validation

  • dotnet build CoreEx.Samples.Build.slnf --no-restore --configuration Release — succeeded with 0 warnings and 0 errors
  • Contoso.Shopping.Test.Unit — 48 passed across net8.0, net9.0, and net10.0
  • Contoso.Shopping.Test.Subscribe — 15 passed across net8.0, net9.0, and net10.0
  • confirmed both projects are selected by both solution filters

Copilot AI review requested due to automatic review settings July 24, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores full CI coverage for the Contoso Shopping sample by adding two previously omitted Shopping test projects back into the repository’s sample build/test solution filters.

Changes:

  • Add Contoso.Shopping.Test.Unit and Contoso.Shopping.Test.Subscribe to CoreEx.Samples.Test.slnf.
  • Add Contoso.Shopping.Test.Unit and Contoso.Shopping.Test.Subscribe to CoreEx.Samples.Build.slnf.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
CoreEx.Samples.Test.slnf Includes Shopping unit + subscriber test projects in the test solution filter so PR CI runs them.
CoreEx.Samples.Build.slnf Includes Shopping unit + subscriber test projects in the build solution filter so PR CI builds them.

@timbarreto
timbarreto force-pushed the fm/coreex-all-tests-opus5 branch 2 times, most recently from 9dda1ec to 8c33060 Compare July 24, 2026 21:59
Signed-off-by: Tim Barreto <timbarreto@users.noreply.github.com>
@timbarreto
timbarreto force-pushed the fm/coreex-all-tests-opus5 branch from 8c33060 to 1702fa8 Compare July 24, 2026 22:11

@chullybun chullybun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pick up. Thanks.

@chullybun
chullybun merged commit e62ea04 into Avanade:main Jul 25, 2026
3 checks passed
@chullybun chullybun added the bug Something isn't working label Jul 25, 2026
@chullybun chullybun added this to the v4.0.0-preview-3 milestone Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants