feat(Clipboard-Bar-Hist): Add search/filter to saved clipboard entries & animation states#2464
Conversation
Purian23
left a comment
Purian23
left a comment
There was a problem hiding this comment.
Thanks for the PR! I tested search on saved/pinned entries and it works great. The ClipboardService filter fix and tab-specific header count look good to me.
Couple of small items:
Please revert the manual en.json changes. That file is auto-generated on its own.
Let's drop the add/remove/displaced/move: null changes, they were intentional. I actually like the list animating while filtering, it feels nicer than an instant snap.
Happy to approve once those are addressed, we appreciate it.
Bodify
force-pushed
the
feature/clipboard-list-tweaks
branch
from
14e35cc to
a06944a
Compare
…s as well. Change title on toggle between recent/saved.
Bodify
force-pushed
the
feature/clipboard-list-tweaks
branch
from
a06944a to
8dc265b
Compare
Done, my bad.
I wouldn't mind some short animations but I can't even say I notice them the way it is now? I only notice the bugs. I'm not entirely sure what the root cause behind it is but keeping the transitions messes everything up same as in #2315. Removing them fixes it. It will probably require a fix elsewhere that is out of my comfort zone and revert the mentioned PR after a proper fix is in place. This is what happens for me if I don't null the animations: filterBug.mp4 |
|
I also made the Pinned/Saved icon stay highlighted when selected to make it more consistent and obvious. Let me know if I should remove the animation nulls or not or what happens there. |
|
After digging a bit more I found the reason: I have Animation Duration set to None/0ms in the Typography & Motion settings. It doesn't like that. I'm not sure of the best way fix to this? I removed the nulling of the animations but it will require a fix for people with None/0ms animations set. That fix is then likely also wanted for this previous change in #2315 |
|
Nice work on this one @Bodify! When you first presented what appeared to be a bug, I was baffled, but with animations turned off it made sense. I pushed an update to allow both states. When animations are off, they will now use the null settings, when they are above zero they will use the animations we put in place. Thanks again! |
Purian23
changed the title
…s & animation states (AvengeMedia#2464) * Fix gaps and overlaps when filtering clipboard history * feat(Clipboard-Bar-Hist): Add search/filter to saved clipboard entries as well. Change title on toggle between recent/saved. * keep Pinned/Saved icon highlighted when selected * add back filter animations * Implement snap state for list views based on animation settings --------- Co-authored-by: purian23 <purian23@gmail.com>
2 participants
DankBar: Enable searching in saved clipboard entries and changes the popup title between "Clipboard History" and "Clipboard Saved" when toggling the Saved/Recent button.
Also fixes search/filter issues for DankBar's Clipboard History similar to #2315