fix(wallpaper): redraw wallpaper layers when fill mode changes#2542
Conversation
| Connections { | ||
| target: SettingsData | ||
| function onWallpaperFillModeChanged() { | ||
| root._renderSettling = true; | ||
| renderSettleTimer.restart(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
While testing this, I noticed an interesting side effect if the fill-mode redraw is only applied to WallpaperBackground and not BlurredWallpaperBackground. With Blur Wallpaper Layer enabled, the blurred duplicate can retain the previous composition while the main wallpaper switches to the new fill mode, which creates a surprisingly nice layered effect. I don't think it should block this fix, but it might be worth considering as an optional feature in the future.
- desktop
- overview
There was a problem hiding this comment.
While testing this, I noticed an interesting side effect if the fill-mode redraw is only applied to WallpaperBackground and not BlurredWallpaperBackground. With Blur Wallpaper Layer enabled, the blurred duplicate can retain the previous composition while the main wallpaper switches to the new fill mode, which creates a surprisingly nice layered effect. I don't think it should block this fix, but it might be worth considering as an optional feature in the future.
- desktop
* overview
I meant this one, this fix addresses both blurred and non-blurred layer for me.
There was a problem hiding this comment.
Yes, I think this could be offered as an optional feature (like Blur wallpaper using a separate wallpaper mode), but it's reasonable to keep it consistent with the main wallpaper until it's determined whether that feature will be supported, so I fixed it in this PR.
What are your thoughts on this feature?
|
I cant reproduce the blurred mode problem honestly, it might just be a matter of bumping the timer duration since it takes longer to draw with the blur |
The reproduction steps are somewhat specific:
Sorry, I'm having some trouble with my clipboard synchronization. |
|
@bbedward Please follow the steps above; the problem should be reproducible. |
2 participants
Fix wallpaper not updating when fill mode changes.