Skip to content

feat(network): expose saved WiFi networks in settings#2648

Merged
bbedward merged 1 commit into
AvengeMedia:masterfrom
jbwfu:feat/settings-saved-wifi
Jun 16, 2026
Merged

feat(network): expose saved WiFi networks in settings#2648
bbedward merged 1 commit into
AvengeMedia:masterfrom
jbwfu:feat/settings-saved-wifi

Conversation

@jbwfu

@jbwfu jbwfu commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Description

Added saved Wi-Fi management.

I'm unsure if it's necessary to increment the API version here.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Refactor / internal cleanup
  • Documentation
  • Other

Related issues

Screenshots / video

Default folded:

image

After expansion:

image

Checklist

  • My code follows the conventions in CONTRIBUTING.md
  • I have tested my changes locally
  • New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
  • Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
  • QML changes: ran make lint-qml with no new warnings
  • I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

@jbwfu

jbwfu commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

It was my oversight; I will fix it later.

@jbwfu jbwfu force-pushed the feat/settings-saved-wifi branch from 556d7b6 to 0e303f2 Compare June 16, 2026 03:05
@jbwfu

jbwfu commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

This force push does not change any behavior. It only extracts the connection check into a local variable so golangci-lint --fix does not rewrite the boolean expression automatically.

CI failed because the remote check runs prek run --all-files, which checks the whole repository and applies auto-fixable lint changes. My local commit hook passed, but it did not run the same all-files check as CI, so it did not catch this rewrite before pushing.

@jbwfu jbwfu marked this pull request as draft June 16, 2026 03:33
@jbwfu jbwfu force-pushed the feat/settings-saved-wifi branch from 0e303f2 to 961d342 Compare June 16, 2026 12:01
@jbwfu jbwfu marked this pull request as ready for review June 16, 2026 12:01
@jbwfu

jbwfu commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Improved support for iwd network backend and updated API version from 25 to 26.

@bbedward bbedward merged commit 85b6321 into AvengeMedia:master Jun 16, 2026
2 checks passed
@jbwfu jbwfu deleted the feat/settings-saved-wifi branch June 16, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants