docs(rook-ceph): update CephX rotation changelog with PR #1398 and Rook v1.20.6 status - #1400
Merged
Merged
Conversation
… and Rook v1.20.6 live status
…1.20.4 baseline row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Update CephX rotation changelog entry: replace PR #TBD placeholder with #1398, and update Rook v1.20.6 prerequisite from pending gate to satisfied (Rook v1.20.6 deployed via PR #1397)
What Changed
docs/ceph-cluster-changelog.mdto reference PR feat(rook-ceph): rotate daemon cephx keys onto aes256k #1398 in place of the#TBDplaceholder, and reworded the section heading from "gated on Rook v1.20.6" to "Rook v1.20.6 live".Risk Assessment
✅ Low: Docs-only, two-line edit to a changelog entry; both new claims (PR #1398 rotation, Rook v1.20.6 via PR #1397) are independently verified as merged via
gh pr viewand the liveocirepository.yamltag, and the edit satisfies the stated intent exactly with no functional code touched.Testing
This is a prose-only edit to docs/ceph-cluster-changelog.md (2 lines changed, no code); I validated it the way an end-user maintainer would, by checking the new claims against ground truth rather than just eyeballing the diff. GitHub confirms PR #1397 ("update rook-ceph group v1.20.4 -> v1.20.6") and PR #1398 ("rotate daemon cephx keys onto aes256k") are both merged, with #1398's merge commit exactly matching this branch's base commit - so the placeholder replacement and the "Prerequisite: Satisfied" wording are both accurate. The live GitOps config (operator/cluster ocirepository.yaml) confirms Rook is indeed pinned to v1.20.6, backing the "Rook v1.20.6 live" claim. The edited markdown table's row structure remains intact. No test failures, no code to unit test, and the worktree is clean with no stray artifacts.Evidence: gh pr view 1397/1398 confirming merge state matches changelog claims
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff 44e98748..3878b2c4 -- docs/ceph-cluster-changelog.md (confirmed only the 2 targeted lines changed)gh pr view 1397 -R Aviator-Coding/home-ops --json number,title,state,mergedAt,mergeCommit (MERGED, v1.20.4->v1.20.6, matches claim)gh pr view 1398 -R Aviator-Coding/home-ops --json number,title,state,mergedAt,mergeCommit (MERGED, merge commit == branch base commit 44e98748, matches claim)grep for tag: v1.20.6 in kubernetes/apps/rook-ceph/rook-ceph/{operator,cluster}/ocirepository.yaml (confirms Rook v1.20.6 is actually live in GitOps config)awk pipe-count check on docs/ceph-cluster-changelog.md lines 86-96 (confirms markdown table structure/row field-count unbroken after edit)git status --porcelain (worktree clean, no stray artifacts)⏭️ **Document** - skipped
docs/ceph/toolbox.md:33- docs/ceph/toolbox.md (lines 33 and 41) and the code comment in kubernetes/apps/rook-ceph/rook-ceph/operator/csi-driver-rbac.yaml (line 11) still say the Rook chart is 'v1.20.4', including arook/ceph:v1.20.4toolbox debug-image example. The live tag is v1.20.6 (confirmed via ocirepository.yaml and the baseline table just corrected in docs/ceph-cluster-changelog.md). This staleness predates this branch - it was introduced by an earlier, already-merged Renovate bump commit that never touched these two files - and is unrelated to this change's PR-number/prerequisite wording fix, so it was left alone here to keep this pass scoped. Worth a small follow-up to sync these version references (and confirm the toolbox debug-image guidance still holds at v1.20.6).✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.