docs: fix stale VictoriaMetrics reference and mod.just quoting bug - #1403
Merged
Conversation
VictoriaMetrics and VictoriaLogs/Vector are commented out and not deployed. Live stack is kube-prometheus-stack + Loki + Promtail + Tempo + Grafana + Alertmanager + Gatus + kromgo + KEDA + unpoller. fix(kubernetes): expand timestamp in snapshot recipe Change single quotes to double quotes in snapshot patch payload so $(date +%s) expands correctly. Previous single-quoting made every invocation after the first a silent no-op.
Aviator-Coding
force-pushed
the
fm/homeops-repo-microfixes
branch
from
August 23, 2026 20:39
c2da3fb to
2480171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix two factual errors: (1) AGENTS.md monitoring stack description is false - VictoriaMetrics/VictoriaLogs/Vector are not deployed; live stack is kube-prometheus-stack + Loki + Promtail + Tempo + Grafana + Alertmanager + Gatus + kromgo + KEDA + unpoller. (2) kubernetes/mod.just snapshot recipe uses single quotes so $(date +%s) writes literally - change to double quotes to expand timestamp.
What Changed
AGENTS.md's core stack description: replaced the inaccurate VictoriaMetrics/VictoriaLogs/Vector monitoring stack with the actual deployed stack - kube-prometheus-stack + Loki + Promtail + Tempo + Grafana + Alertmanager + Gatus + kromgo + KEDA + unpoller.docs/downloads/sabnzbd-disk-space-runbook.mdto state that PrometheusRules are consumed natively by kube-prometheus-stack's Prometheus Operator, replacing the stale reference to a VictoriaMetrics operator PrometheusRule-to-VMRule converter.snapshotrecipe inkubernetes/mod.justto use double quotes around thekubectl patchJSON payload so$(date +%s)expands to the current timestamp instead of being written literally.Risk Assessment
✅ Low: Two isolated, verified-correct fixes (one doc correction confirmed against the actual monitoring kustomization.yaml, one shell-quoting fix confirmed to expand correctly and consistent with an existing working pattern in the same file) with no functional or behavioral risk beyond their stated scope.
Testing
Verified the diff between base 12b2a76 and target 5cb03f5 contains exactly the two intended changes (no unrelated edits). For fix #1, cross-checked the corrected AGENTS.md monitoring-stack sentence against kubernetes/apps/monitoring/kustomization.yaml and confirmed VictoriaMetrics/VictoriaLogs/Vector are present as directories but commented out of the namespace's resource list (not deployed), while every app named in the fixed text (kube-prometheus-stack, Loki, Promtail, Tempo, Grafana, Alertmanager, Gatus, kromgo, KEDA, unpoller) is an active resource. For fix #2, reproduced the bug end-to-end by extracting the actual snapshot recipe body from both commits and executing each under the same shell
justconfigures (bash -euo pipefail -c) with a stubbed kubectl capturing its patch payload: the base (single-quoted) version sent the literal, non-expanding string "$(date +%s)" to kubectl patch, while the target (double-quoted) version sent a real expanded epoch timestamp, confirming the fix works as intended. No linters or test suites were run per phase scope; worktree left clean with no leftover test artifacts.Evidence: End-to-end reproduction of mod.just snapshot recipe: base (single-quoted) sends literal $(date +%s) vs target (double-quoted) sends expanded timestamp
Evidence: kubernetes/apps/monitoring/kustomization.yaml confirming VictoriaMetrics/VictoriaLogs/Vector are commented out (not deployed)
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff 12b2a76a45986c7165b157ecbb44fc16d3267752 5cb03f59c857ddd66bff5b45bba11bdb476111ff (confirmed scope: only AGENTS.md and kubernetes/mod.just changed)Inspected kubernetes/apps/monitoring/kustomization.yaml to confirm victoriametrics/victorialogs/vector are commented out and the other named apps are activeManual end-to-end reproduction: extracted the snapshot recipe body from both commits and ran each viabash -euo pipefail -c(just's configured shell) with a stubbed kubectl function, comparing the literal patch payload sent in each casegit status --porcelain (confirmed worktree clean after testing, no residue)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.