Proposal: add more thorough coverage of the crate to CI#41
Merged
Axect merged 6 commits intoAxect:masterfrom Apr 25, 2025
Merged
Proposal: add more thorough coverage of the crate to CI#41Axect merged 6 commits intoAxect:masterfrom
Axect merged 6 commits intoAxect:masterfrom
Conversation
- Verify formatting - Run a cargo check - Run clippy - Generate docs - Build the crate - Test the crate on both stable and beta Rust channels - Verify semver-compatibillity - Check that all examples compile and run
This requires the host to have a bunch of python packages installed, as well as LaTeX, and I do not know how to do that in CI
Contributor
Author
|
I removed the job that runs all examples because I do not know how to install all required dependencies in CI. |
Contributor
Author
|
The current complaints of clippy might be interesting to look at, either to decide that they should be ignored, or to fix (but if so, probably in a different PR). |
This comment was marked as resolved.
This comment was marked as resolved.
Merged
Axect
approved these changes
Apr 25, 2025
Owner
|
Thanks again for your great contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some of my crates I have collected some useful CI jobs over time, and thought they might be interesting here to!
This PR adds a lot of checks of the crate to CI. All these things are either nice to have verified whenever new code is added to the crate, or nice to know before releasing a new version.
Check that all examples compile and run