Fix clippy lints#44
Conversation
It does not actually document the item it decorates
It does not document only the item it decorates.
|
It is completely reasonable to object to some of these changes, in which case I will undo them, and we can allow the clippy lint that suggests them. |
We only need it sometimes, and only one of the values are ever used at a time, so we do not need to store anything.
Makes for easier conversion to "no_std" if desired in the future.
|
Thank you so much for putting in all this effort to address the clippy lints! We really appreciate your contribution. Great work! Regarding your points about potential objections and the offer to revert changes: thanks for considering that and being open to feedback. For now, let's stick with following the clippy suggestions, including the underscore insertions. We can follow the lint rules for the time being. If they turn out to be genuinely inconvenient or problematic as we continue working, we can definitely revisit and adjust them later. Thanks for bringing it up! |
This PR goes through all the lint warnings generated by
cargo clippydiscovered in #41, and either follows the suggestion or does something more appropriate to fix them.Overview of changes
return x;at the end of a block have been changed to justx.containsfunction on that range.FRAC_2_SQRT_PIfrom thecore::f64::constsmodule.consts have been converted intostatics.