Some quick fixes and refactors - #154
Merged
Merged
Conversation
Both engines activated the replacement before storing its trampoline, so a thread entering the detour in that window called through a null pointer. Fixes #151
The resend gate keys on is_connected(), so setting it first let a game tick flush the previous seed's checked set to the newly connected server.
The mod is dlopened into the game's process, so its 5100 exported symbols were interposition surface against the host and any other mod; now only MinaMod_Init is exported.
Its only caller was an unreachable fallback for a null overlay UI, so ~9k lines of demo code were compiled into both binaries for nothing.
The comment claimed an exact-commit pin while the tag tracks main, which reads as a bug to fix rather than the deliberate choice it is.
on_game_update and on_update_queue were never overridden, so Game::Update and ycUpdateQueue::Update carried live detours whose only effect was an empty call.
rva() and find_symbol() had no callers, and install_listener was a pure virtual that forced both engines to carry a stub that only logged and failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.